From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B79DC2D0E8 for ; Fri, 3 Apr 2020 11:04:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D0492073B for ; Fri, 3 Apr 2020 11:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D0492073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E2AD8E0008; Fri, 3 Apr 2020 07:04:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 892AF8E0007; Fri, 3 Apr 2020 07:04:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8808E0008; Fri, 3 Apr 2020 07:04:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 5DEE78E0007 for ; Fri, 3 Apr 2020 07:04:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1D139181AC537 for ; Fri, 3 Apr 2020 11:04:02 +0000 (UTC) X-FDA: 76666259124.11.lunch42_7a7d9314db14f X-HE-Tag: lunch42_7a7d9314db14f X-Filterd-Recvd-Size: 3803 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 11:04:01 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id m17so7968001wrw.11 for ; Fri, 03 Apr 2020 04:04:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uKZeJ3QaYya1YXVrP4ptZzn73kQ2uIA9YdMAiYW3qiU=; b=HINOptA3RVb7XV6bfWtZUu1d6niUUSWsQgIomeg2Lu3jsbg5Qnse92tnJZdwgZmguI 5ntcgX3AaCCaAHmr5+/3ejNd1ij3LJFirJu7OYaGaBJ15MFGGpVb63Phq26fBT5DK7wq GUfXIG0ZH0WsfgjafzqOdn0/1CtqfOA2dSxaMmeuTqFyHUB7LM6zKohPZZXJXnUUt/Ah A4Wpy+gCYN3Aet2Rg4OH111YHYTvxummfvpWHJmDQ6yfvav7c4dKmSMc4LwH48QUbsJr ILAxDYpvgr426gvU2CfxexaoT+mtyAPJD5hCrK9VNeDGHhMzAM9j5N9UkeJPgamMJ03M G/oQ== X-Gm-Message-State: AGi0Pubcpq3mqUwXjes7N3aagT4gfTVYrZfbdF5WgKyrcu0bHcm8D2Gq xmYbb05IbUkrArR7gADR4d4= X-Google-Smtp-Source: APiQypLnsyKoca02cmMgitG6rzlmlWsncnvAW+5wBYZxxmEKLfRML3tOIzzWKNmTrdgpKhbofj5NbQ== X-Received: by 2002:a05:6000:1205:: with SMTP id e5mr8928579wrx.73.1585911840404; Fri, 03 Apr 2020 04:04:00 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id 189sm11405996wme.31.2020.04.03.04.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 04:03:59 -0700 (PDT) Date: Fri, 3 Apr 2020 13:03:58 +0200 From: Michal Hocko To: Jan Kara Cc: NeilBrown , Christoph Hellwig , Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 2/2 - v2] MM: Discard NR_UNSTABLE_NFS, use NR_WRITEBACK instead. Message-ID: <20200403110358.GB22681@dhcp22.suse.cz> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87sghmyd8v.fsf@notabene.neil.brown.name> <87pncqyd7k.fsf@notabene.neil.brown.name> <20200402151009.GA14130@infradead.org> <87h7y1y0ra.fsf@notabene.neil.brown.name> <20200403094220.GA29920@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200403094220.GA29920@quack2.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 03-04-20 11:42:20, Jan Kara wrote: [...] > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 78d53378db99..d1291537bbb9 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -1162,7 +1162,6 @@ const char * const vmstat_text[] = { > > "nr_file_hugepages", > > "nr_file_pmdmapped", > > "nr_anon_transparent_hugepages", > > - "nr_unstable", > > "nr_vmscan_write", > > "nr_vmscan_immediate_reclaim", > > "nr_dirtied", > > This is probably the most tricky to deal with given how /proc/vmstat is > formatted. OTOH for this file there's good chance we'd get away with just > deleting nr_unstable line because there are entries added to it in the > middle (e.g. in 60fbf0ab5da1 last September) and nobody complained yet. > > What do mm people think? How were changes to vmstat counters handled in the > past? Adding new counters in the middle seems to be generally OK. I would be more worried about removing counters though. So if we can simply print a phone value at the very end then this should be a reasonable workaround. -- Michal Hocko SUSE Labs