From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C867C43331 for ; Thu, 2 Apr 2020 17:16:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 986CA20757 for ; Thu, 2 Apr 2020 17:16:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 986CA20757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 34DF48E0009; Thu, 2 Apr 2020 13:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEEE8E0007; Thu, 2 Apr 2020 13:16:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ED498E0009; Thu, 2 Apr 2020 13:16:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 052548E0007 for ; Thu, 2 Apr 2020 13:16:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C9BF92C94 for ; Thu, 2 Apr 2020 17:16:35 +0000 (UTC) X-FDA: 76663569150.24.view92_73c34d8432956 X-HE-Tag: view92_73c34d8432956 X-Filterd-Recvd-Size: 3676 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 17:16:35 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id 91so3227581wri.10 for ; Thu, 02 Apr 2020 10:16:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wSJgn6y+TnPhKVbxYRczrw0YlPLaTZQeeEt5dFsH/O0=; b=YrCCWzBKfSDHQKRiIJ+S0qvFmYlBnvYjBTSMZnbEXEzWiJUfjLZnHXq93XZUNgS9Sk E1lJb1Wn7JrLHxJrlAY507QkmZvVlT95YJULYj4Euc71ZrA+O/cth5DKpWHTiOA2DGMU GivoLc5bi+bc7UoxzkvS2soc65Q/ltE8WojRwaxJSt1wvNaie/7fW6RWvIAVo78I7fCI KV+7uRU6tsMYBwoWH1tj0x0fNsKznY7XDS3CcsgNoBfIbTichT/3lZaN6LOgF71jD55C p0TZ1cws7XUzvorYH9/YFJDa20NerH+EiZYWRjVG/sKwysfHT7dXIp0VCrkyLbuVXzMx Wffw== X-Gm-Message-State: AGi0PuYxyocvHQk7UAVZ5xtFzJNsYqvrB0ACGovaIzorthS4AKITLf7h Wcnhcnx7X8TkXR/ZPNnuH3E= X-Google-Smtp-Source: APiQypIWtH7Pfnug8iU1zL15G60DAQmAUS0fYXs9+ehtubvusYTQQj++dv8yoYgYp85u4+rIix2yIw== X-Received: by 2002:a5d:4f08:: with SMTP id c8mr4636754wru.27.1585847794165; Thu, 02 Apr 2020 10:16:34 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id k3sm8396362wrw.61.2020.04.02.10.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 10:16:33 -0700 (PDT) Date: Thu, 2 Apr 2020 19:16:31 +0200 From: Michal Hocko To: Pavel Tatashin Cc: David Hildenbrand , LKML , Andrew Morton , linux-mm , Dan Williams , Shile Zhang , Daniel Jordan , Kirill Tkhai , James Morris , Sasha Levin , Vlastimil Babka Subject: Re: [PATCH v2 2/2] mm: initialize deferred pages with interrupts enabled Message-ID: <20200402171631.GU22681@dhcp22.suse.cz> References: <20200401225723.14164-1-pasha.tatashin@soleen.com> <20200401225723.14164-3-pasha.tatashin@soleen.com> <20200402074732.GJ22681@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 02-04-20 11:13:49, Pavel Tatashin wrote: > > > I do wonder if this change is strictly required in this patch (IOW, if > > > we could keep calling touch_nmi_watchdog() also without holding a spinlock) > > > > Exactly. I would go with your patch on top. > > > > > Anyhow, it's the right thing to do. > > Michal, > > The reason I changed it here is because in the original patch that > this patch fixes we changed cond_sched() to touch_nmi_watchdog(): > $ git show 3a2d7fa8a3d5 | grep -E '(nmi|sched)' > - cond_resched(); > + touch_nmi_watchdog(); > - cond_resched(); > + touch_nmi_watchdog(); > > So, should I move it to a separate patch or is it OK to keep it here? Having in a separate patch would be better IMO. If for nothing else, the RCU stall would be easier to see. -- Michal Hocko SUSE Labs