From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C78EC43331 for ; Thu, 2 Apr 2020 04:11:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14DE02074D for ; Thu, 2 Apr 2020 04:11:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZekcM7OY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14DE02074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB7208E008A; Thu, 2 Apr 2020 00:11:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B680C8E000D; Thu, 2 Apr 2020 00:11:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4B18E008A; Thu, 2 Apr 2020 00:11:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 902788E000D for ; Thu, 2 Apr 2020 00:11:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5A7134995E0 for ; Thu, 2 Apr 2020 04:11:03 +0000 (UTC) X-FDA: 76661589606.18.shoe63_608007ff3e11c X-HE-Tag: shoe63_608007ff3e11c X-Filterd-Recvd-Size: 2468 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:11:03 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21A362074D; Thu, 2 Apr 2020 04:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800662; bh=CY3ZHmfp8suKD+4ZuIx95zMcvWPw8DlrOz+05PWlUlI=; h=Date:From:To:Subject:In-Reply-To:From; b=ZekcM7OYoqkj5wzJZ79YnZ0RcMo1p2AxLO9GENOpEGl4e+tYNPuBGJ34rt9GocF4s 6q9oFaJVYcsiaJI9gvTP/WHYsTmKdJ5c5uBK4Cq/AozmHZ5ou+T5OuHq2W+eKAbsdj faGTFwW9BXScnhyca8Vbe6ZMJk+eK5it0Ts92WfQ= Date: Wed, 01 Apr 2020 21:11:01 -0700 From: Andrew Morton To: akpm@linux-foundation.org, colin.king@canonical.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, pankaj.gupta.linux@gmail.com, rppt@linux.ibm.com, torvalds@linux-foundation.org Subject: [patch 138/155] mm/memblock.c: remove redundant assignment to variable max_addr Message-ID: <20200402041101.wNZJJ4wMk%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Colin Ian King Subject: mm/memblock.c: remove redundant assignment to variable max_addr The variable max_addr is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Link: http://lkml.kernel.org/r/20200228235003.112718-1-colin.king@canonical.com Signed-off-by: Colin Ian King Reviewed-by: Pankaj Gupta Reviewed-by: Mike Rapoport Signed-off-by: Andrew Morton --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/memblock.c~mm-memblock-remove-redundant-assignment-to-variable-max_addr +++ a/mm/memblock.c @@ -1698,7 +1698,7 @@ static phys_addr_t __init_memblock __fin void __init memblock_enforce_memory_limit(phys_addr_t limit) { - phys_addr_t max_addr = PHYS_ADDR_MAX; + phys_addr_t max_addr; if (!limit) return; _