From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FC2C43331 for ; Thu, 2 Apr 2020 04:10:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C87372074D for ; Thu, 2 Apr 2020 04:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PEyJJwBX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C87372074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BE578E0088; Thu, 2 Apr 2020 00:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 771A78E000D; Thu, 2 Apr 2020 00:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68BDA8E0088; Thu, 2 Apr 2020 00:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 488438E000D for ; Thu, 2 Apr 2020 00:10:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 161008248068 for ; Thu, 2 Apr 2020 04:10:57 +0000 (UTC) X-FDA: 76661589354.13.point19_5f9673d832104 X-HE-Tag: point19_5f9673d832104 X-Filterd-Recvd-Size: 2481 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:10:56 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1D6820784; Thu, 2 Apr 2020 04:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800656; bh=AReACJUcX3c/jtDOGcqJ8bUk4Rh/FtIcMICvbrAWLbE=; h=Date:From:To:Subject:In-Reply-To:From; b=PEyJJwBX823rRd2cOqIvQ722dPI71ecaYsvmBAIPe6nkr14yzXQ7ewClC8Py8Ay06 dyYbzLwGohPgPTvQmBpNBwR/Sy7IfkDLvB6exnxpLSnCPPfRKrugFDAROOjqtvm9TE dHmw53MUlDiotQ3hefzbZMjiKmYfnXyEnluQZaIU= Date: Wed, 01 Apr 2020 21:10:55 -0700 From: Andrew Morton To: akpm@linux-foundation.org, cai@lca.pw, linux-mm@kvack.org, lixinhai.lxh@gmail.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, yang.shi@linux.alibaba.com Subject: [patch 136/155] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() Message-ID: <20200402041055.o8u300uTM%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Shi Subject: mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() The VM_BUG_ON() is already used by queue_pages_test_walk(), it sounds better to dump more debug information by using VM_BUG_ON_VMA() to help debugging. Link: http://lkml.kernel.org/r/1579068565-110432-1-git-send-email-yang.shi@linux.alibaba.com Signed-off-by: Yang Shi Reviewed-by: Andrew Morton Cc: "Li Xinhai" Cc: Qian Cai Signed-off-by: Andrew Morton --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/mempolicy.c~mm-mempolicy-use-vm_bug_on_vma-in-queue_pages_test_walk +++ a/mm/mempolicy.c @@ -650,7 +650,7 @@ static int queue_pages_test_walk(unsigne unsigned long flags = qp->flags; /* range check first */ - VM_BUG_ON((vma->vm_start > start) || (vma->vm_end < end)); + VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma); if (!qp->first) { qp->first = vma; _