From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1390C43331 for ; Thu, 2 Apr 2020 04:02:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6053206E9 for ; Thu, 2 Apr 2020 04:02:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nle1LyeT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6053206E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 444208E000A; Thu, 2 Apr 2020 00:02:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F3C58E0007; Thu, 2 Apr 2020 00:02:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3304E8E000A; Thu, 2 Apr 2020 00:02:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 1C4C68E0007 for ; Thu, 2 Apr 2020 00:02:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D024C180AD80F for ; Thu, 2 Apr 2020 04:02:30 +0000 (UTC) X-FDA: 76661568060.01.bulb93_15e8713b8e662 X-HE-Tag: bulb93_15e8713b8e662 X-Filterd-Recvd-Size: 3009 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:02:30 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67DE22078B; Thu, 2 Apr 2020 04:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800149; bh=sx1Sbl27qS6BHi0vlPQ1M8vkJeo/wOYo1U43I+i+8MA=; h=Date:From:To:Subject:In-Reply-To:From; b=Nle1LyeTLoeezqwjjFQk6BM069Ho1SnuH9v4uvjhMbJ9ZLbS1uHzCcKlWIvgD3AOQ JehkBp8mZc7g8hogmkefm7rI6Jzd2cbctCp5NLjee5eAJlWJTgM6AuqBuqzAzStfEu Uu0ugvw1rZ9QdQ/J0aW8aVFx3K579lww+56SAqVc= Date: Wed, 01 Apr 2020 21:02:28 -0700 From: Andrew Morton To: akpm@linux-foundation.org, grygorii.strashko@ti.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, pmladek@suse.com, tglx@linutronix.de, tj@kernel.org, torvalds@linux-foundation.org Subject: [patch 002/155] kthread: mark timer used by delayed kthread works as IRQ safe Message-ID: <20200402040228.SUm4aLepC%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Petr Mladek Subject: kthread: mark timer used by delayed kthread works as IRQ safe The timer used by delayed kthread works are IRQ safe because the used kthread_delayed_work_timer_fn() is IRQ safe. It is properly marked when initialized by KTHREAD_DELAYED_WORK_INIT(). But TIMER_IRQSAFE flag is missing when initialized by kthread_init_delayed_work(). The missing flag might trigger invalid warning from del_timer_sync() when kthread_mod_delayed_work() is called with interrupts disabled. This patch is result of a discussion about using the API, see https://lkml.kernel.org/r/cfa886ad-e3b7-c0d2-3ff8-58d94170eab5@ti.com Link: http://lkml.kernel.org/r/20200217120709.1974-1-pmladek@suse.com Signed-off-by: Petr Mladek Reported-by: Grygorii Strashko Tested-by: Grygorii Strashko Acked-by: Tejun Heo Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- include/linux/kthread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/include/linux/kthread.h~kthread-mark-timer-used-by-delayed-kthread-works-as-irq-safe +++ a/include/linux/kthread.h @@ -165,7 +165,8 @@ extern void __kthread_init_worker(struct do { \ kthread_init_work(&(dwork)->work, (fn)); \ timer_setup(&(dwork)->timer, \ - kthread_delayed_work_timer_fn, 0); \ + kthread_delayed_work_timer_fn, \ + TIMER_IRQSAFE); \ } while (0) int kthread_worker_fn(void *worker_ptr); _