From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECFCC2BA13 for ; Thu, 2 Apr 2020 07:40:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 180CF208E0 for ; Thu, 2 Apr 2020 07:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZgYWh0h+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 180CF208E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE0118E0009; Thu, 2 Apr 2020 03:40:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB57B8E0007; Thu, 2 Apr 2020 03:40:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACC1D8E0009; Thu, 2 Apr 2020 03:40:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 933D98E0007 for ; Thu, 2 Apr 2020 03:40:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 50EAC181AEF09 for ; Thu, 2 Apr 2020 07:40:53 +0000 (UTC) X-FDA: 76662118386.08.work36_24d2e30d7a44c X-HE-Tag: work36_24d2e30d7a44c X-Filterd-Recvd-Size: 6852 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 07:40:52 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id m15so1186465pje.3 for ; Thu, 02 Apr 2020 00:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rRniYv7RPwWHFWrPJUZ8iMNVA0tUTHJrCguWpqpN+6k=; b=ZgYWh0h+a5Hg2gYuDaf7bAJw/KFnrjKUiEuvbptyyu8Ds6OObwEJ9RIl0P+Ognz7ON aVcJvZkmoY5pTE9Oigwg6Rz73WgiRqYNakHvrmSrDodIpjaHrTg1KZr/8/65eN0WM5/I HNXT2GWnBGZf3TIUSbj5+3eAx6Fzc29HW0q/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rRniYv7RPwWHFWrPJUZ8iMNVA0tUTHJrCguWpqpN+6k=; b=Z95Y+mPrQGK7z8WTd8w+DRHVI9YalwDzWNYXiEoddyl/nG9cFxjtZkn7NyqeulI0ok GNfsrO4XXstU/n3f28fuxfbpPoLPDqB7uqfaLPAkPdJ1stUwTHnsZL8RYRwGIVCjx5W9 JeJSxOPcji88Ttlqt8SMO6ZeAVGHnKDlJMk4HCN+YuwgA0f9DlRJsl8dAfHlKSymhK8j YmqQCmfHpO0i/1bY1A6kRYOZqbSf3ME8zagsHNTGTYyWEX87fiRo4bmcV5IzphBI4tAY ph33AN1uQR34OgUcBQPSeOcaeQYTY8Lh0GSLy/5ciVgN9upKnj2ngDWIF5TI98XgUbuv vBhQ== X-Gm-Message-State: AGi0PuZJW1aEhhW1HMIlMzgbZXSQ1m6M20q8pvbb0ZnGuzIld++j2wSf 8nIRjaIrgGhsjV1rICaiB/ieNA== X-Google-Smtp-Source: APiQypI2cYt4enOL7sTbasi+WDYQtLGOhHbbnJYUSxIit5amZbHaBwsNKTd/VramUXhMpxHV80lNww== X-Received: by 2002:a17:902:a706:: with SMTP id w6mr1769890plq.79.1585813251785; Thu, 02 Apr 2020 00:40:51 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 8sm3137514pfy.130.2020.04.02.00.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 00:40:50 -0700 (PDT) Date: Thu, 2 Apr 2020 00:40:09 -0700 From: Kees Cook To: Matthew Wilcox Cc: Bernd Edlinger , "Eric W. Biederman" , Greg Kroah-Hartman , Kirill Tkhai , Christian Brauner , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v6 00/16] Infrastructure to allow fixing exec deadlocks Message-ID: <202004020037.67ED66C8B6@keescook> References: <871rpg8o7v.fsf@x220.int.ebiederm.org> <202003282041.A2639091@keescook> <20200330201459.GF22483@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330201459.GF22483@bombadil.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 30, 2020 at 01:14:59PM -0700, Matthew Wilcox wrote: > On Mon, Mar 30, 2020 at 10:12:02PM +0200, Bernd Edlinger wrote: > > On 3/29/20 5:44 AM, Kees Cook wrote: > > > On Sat, Mar 28, 2020 at 11:32:35PM +0100, Bernd Edlinger wrote: > > >> Oh, do I understand you right, that I can add a From: in the > > >> *body* of the mail, and then the From: in the MIME header part > > >> which I cannot change is ignored, so I can make you the author? > > > > > > Correct. (If you use "git send-email" it'll do this automatically.) > > > > > > e.g., trimmed from my workflow: > > > > > > git format-patch -n --to "$to" --cover-letter -o outgoing/ \ > > > --subject-prefix "PATCH v$version" "$SHA" > > > edit outgoing/0000-* > > > git send-email --transfer-encoding=8bit --8bit-encoding=UTF-8 \ > > > --from="$ME" --to="$to" --cc="$ME" --cc="...more..." outgoing/* > > > > > > > > > > Okay, thanks, I see that is very helpful information for me, and in > > this case I had also fixed a small bug in one of Eric's patches, which > > was initially overlooked (aquiring mutexes in wrong order, > > releasing an unlocked mutex in some error paths). > > I am completely unexperienced, and something that complex was not > > expected to happen :-) so this is just to make sure I can handle it > > correctly if something like this happens again. > > > > In the case of PATCH v6 05/16 I removed the Reviewd-by: Bernd Edlinger > > since it is now somehow two authors and reviewing own code is obviously > > not ok, instead I added a Signed-off-by: Bernd Edlinger (and posted the > > whole series on Eric's behalf (after asking Eric's permissing per off-list > > e-mail, which probably ended in his spam folder) > > > > Is this having two Signed-off-by: for mutliple authors the > > correct way to handle a shared authorship? > > If the patch comes through you, then Reviewed-by: is inappropriate. > Instead, you should use Signed-off-by: in the second sense of > Documentation/process/submitting-patches.rst > > This also documents how to handle "minor changes" that you make. And in the true case of multiple authors, have both SoBs, but also add a Co-developed-by: for the non-"git author" author. Specific details: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by -- Kees Cook