From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2C9C43331 for ; Wed, 1 Apr 2020 19:57:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2722A206F6 for ; Wed, 1 Apr 2020 19:57:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2722A206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A43018E0007; Wed, 1 Apr 2020 15:57:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F3208E0006; Wed, 1 Apr 2020 15:57:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F1F8E0007; Wed, 1 Apr 2020 15:57:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 789598E0006 for ; Wed, 1 Apr 2020 15:57:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2C3C952CC for ; Wed, 1 Apr 2020 19:57:25 +0000 (UTC) X-FDA: 76660345650.28.fly72_687ff1c2942c X-HE-Tag: fly72_687ff1c2942c X-Filterd-Recvd-Size: 6176 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 19:57:24 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id a25so1602841wrd.0 for ; Wed, 01 Apr 2020 12:57:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BfeWMzPG/CsGUhWdM7BSSj5928zUrkpDblF4iYmrPrM=; b=HP3TAd8jiVmFYnjuwTW8rQZIus5NaNxzNhwvgj/sg9Z+3mlXfNK8sVXNmi8IsLtsc5 +4JJ6dIAT3ET+1/wVPxPDL9UeWO/loJoi+9qMfQQyjXyF0+tjUPv03vjdo0EkYzAZGvi 4wFZ2bg1/+k6foyKkcBzEW4K7HBjG2RrXCAw2CL/liGbij0aFfErIrmopbdD0rwjajO3 7efrKthy8DWTvOfsMtlF8HSglO0DJnMfUAwvkDMySKnPmfTmeQJn5Q4nI3iq5fjwgsYe CeveHXS1IMTn8wVtijftP4PZEnsu8pO9rophE7pc+BoK7uxLUxuYrgiB800eaSZj9ZtU iBqQ== X-Gm-Message-State: ANhLgQ3LVSGWARwwDk8TWf6xnm03krL1VAWZC3/0Ic7SDrnulnFxm6x1 g9yspEtUb8TlV9DlVRqUnAA= X-Google-Smtp-Source: ADFU+vsQeWJS1uRThwStGyZu2I+V/ABE4rBeGsFnkUIAkO6jmYykRntRGlDR5OiGA/xsHvUzxRwr7w== X-Received: by 2002:a5d:6187:: with SMTP id j7mr28807567wru.419.1585771043649; Wed, 01 Apr 2020 12:57:23 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id a124sm3813626wmd.37.2020.04.01.12.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 12:57:22 -0700 (PDT) Date: Wed, 1 Apr 2020 21:57:21 +0200 From: Michal Hocko To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, dan.j.williams@intel.com, shile.zhang@linux.alibaba.com, daniel.m.jordan@oracle.com, ktkhai@virtuozzo.com, david@redhat.com, jmorris@namei.org, sashal@kernel.org Subject: Re: [PATCH] mm: initialize deferred pages with interrupts enabled Message-ID: <20200401195721.GZ22681@dhcp22.suse.cz> References: <20200401193238.22544-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200401193238.22544-1-pasha.tatashin@soleen.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 01-04-20 15:32:38, Pavel Tatashin wrote: > Initializing struct pages is a long task and keeping interrupts disabled > for the duration of this operation introduces a number of problems. > > 1. jiffies are not updated for long period of time, and thus incorrect time > is reported. See proposed solution and discussion here: > lkml/20200311123848.118638-1-shile.zhang@linux.alibaba.com http://lkml.kernel.org/r/20200311123848.118638-1-shile.zhang@linux.alibaba.com > 2. It prevents farther improving deferred page initialization by allowing > inter-node multi-threading. > > We are keeping interrupts disabled to solve a rather theoretical problem > that was never observed in real world (See 3a2d7fa8a3d5). > > Lets keep interrupts enabled. In case we ever encounter a scenario where > an interrupt thread wants to allocate large amount of memory this early in > boot we can deal with that by growing zone (see deferred_grow_zone()) by > the needed amount before starting deferred_init_memmap() threads. > > Before: > [ 1.232459] node 0 initialised, 12058412 pages in 1ms > > After: > [ 1.632580] node 0 initialised, 12051227 pages in 436ms > Fixes: 3a2d7fa8a3d5 ("mm: disable interrupts while initializing deferred pages") > Signed-off-by: Pavel Tatashin I would much rather see pgdat_resize_lock completely out of both the allocator and deferred init path altogether but this can be done in a separate patch. This one looks slightly safer for stable backports. To be completely honest I would love to see the resize lock go away completely. That might need a deeper thought but I believe it is something that has never been done properly. Acked-by: Michal Hocko Thanks! > --- > mm/page_alloc.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3c4eb750a199..4498a13b372d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1792,6 +1792,13 @@ static int __init deferred_init_memmap(void *data) > BUG_ON(pgdat->first_deferred_pfn > pgdat_end_pfn(pgdat)); > pgdat->first_deferred_pfn = ULONG_MAX; > > + /* > + * Once we unlock here, the zone cannot be grown anymore, thus if an > + * interrupt thread must allocate this early in boot, zone must be > + * pre-grown prior to start of deferred page initialization. > + */ > + pgdat_resize_unlock(pgdat, &flags); > + > /* Only the highest zone is deferred so find it */ > for (zid = 0; zid < MAX_NR_ZONES; zid++) { > zone = pgdat->node_zones + zid; > @@ -1812,8 +1819,6 @@ static int __init deferred_init_memmap(void *data) > while (spfn < epfn) > nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn); > zone_empty: > - pgdat_resize_unlock(pgdat, &flags); > - > /* Sanity check that the next zone really is unpopulated */ > WARN_ON(++zid < MAX_NR_ZONES && populated_zone(++zone)); > > @@ -1854,18 +1859,6 @@ deferred_grow_zone(struct zone *zone, unsigned int order) > return false; > > pgdat_resize_lock(pgdat, &flags); > - > - /* > - * If deferred pages have been initialized while we were waiting for > - * the lock, return true, as the zone was grown. The caller will retry > - * this zone. We won't return to this function since the caller also > - * has this static branch. > - */ > - if (!static_branch_unlikely(&deferred_pages)) { > - pgdat_resize_unlock(pgdat, &flags); > - return true; > - } > - > /* > * If someone grew this zone while we were waiting for spinlock, return > * true, as there might be enough pages already. > -- > 2.17.1 > -- Michal Hocko SUSE Labs