From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688CAC43331 for ; Wed, 1 Apr 2020 19:32:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2541F20714 for ; Wed, 1 Apr 2020 19:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="nkvhrcmU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2541F20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C50718E0007; Wed, 1 Apr 2020 15:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C014E8E0006; Wed, 1 Apr 2020 15:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF468E0007; Wed, 1 Apr 2020 15:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 988148E0006 for ; Wed, 1 Apr 2020 15:32:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5D1CF181AEF0B for ; Wed, 1 Apr 2020 19:32:42 +0000 (UTC) X-FDA: 76660283364.21.size54_51c909ad57e46 X-HE-Tag: size54_51c909ad57e46 X-Filterd-Recvd-Size: 5729 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 19:32:41 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id b62so1327137qkf.6 for ; Wed, 01 Apr 2020 12:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id; bh=8sYcdfSwvJ7GU27ydMWlYk6GPFp2IEn+qpWqN6lfgv8=; b=nkvhrcmUfagpr2oQYYqjbotL3Vw0ugDYVnuHKd1hN6z5UqMf/7JJuzuXJBvhm3IR1w cjghLDInZI9fi2X+8gk26/W4tD5pyu5rvsDTZkRpP8fcayYp+LUkIHRXYaKF6+9yxt/U 6de6nc0uxXpa8PTG8wVKzwPpOJdl/XR5JsyNTyrp6ueVFekd63TCU3lkX3qxzfJ5UaAT +maDA1h6rLGgXHZJ0WczttOLiHD6Cb3LZNy10bE1jvwQdxvQjFkkhvJ4IbHGkPvSYWWr V8B15YCVgLLydloCG/DjTaQsRI46585Y+gydNkNS3J5V7WkmOXHzCbbChYq78buTdtEQ VTHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=8sYcdfSwvJ7GU27ydMWlYk6GPFp2IEn+qpWqN6lfgv8=; b=WKhXiII/gaTUh3MOAP7SIdIA/WryjpSPowmDkMG3cJUJCHLk+QuZEDZhlO59QKCcrj xzccYhZ2zSglcSDgCgL2JVEKBDkGfP1IXWauh2dpPf2I3apOqWd3qAOP4XL/9HXrp5o+ nOOVRtpN5Ej/u+5K3M1BaJJl82DP4Zfg2mvFujx85YjZYiNh3xF9AnUMEZ2hHC8JyrBw I2LD/0sRpPPcUUjFrhg7x8rgXzrjndFxVdFDsztudK6GcpORc8VZxnOoxpj4AYBTB5xM nVdyjnWtSNKpdcZJbqCl79cVpc1I93CFxLzv5+15vzMghaZubnzqWvZRaOWI+wv3kycE cVSw== X-Gm-Message-State: ANhLgQ0sqsm7hWxU4ITWZrOjC9yrb5Pe5+hpHAj5eI31i0KvKxQ2DEKT LLS+uF9rWrvAuyvQPb0i/rJN2Q== X-Google-Smtp-Source: ADFU+vuPQVF2n6nuyNe96HQIiCQgRwZKROr5AyHweWIc1rG+54male7SxFwauWXmFTfMxzBZGD993Q== X-Received: by 2002:a37:66cf:: with SMTP id a198mr11805930qkc.203.1585769560393; Wed, 01 Apr 2020 12:32:40 -0700 (PDT) Received: from localhost.localdomain (c-73-69-118-222.hsd1.nh.comcast.net. [73.69.118.222]) by smtp.gmail.com with ESMTPSA id y132sm2040516qka.19.2020.04.01.12.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 12:32:39 -0700 (PDT) From: Pavel Tatashin To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com, shile.zhang@linux.alibaba.com, daniel.m.jordan@oracle.com, pasha.tatashin@soleen.com, ktkhai@virtuozzo.com, david@redhat.com, jmorris@namei.org, sashal@kernel.org Subject: [PATCH] mm: initialize deferred pages with interrupts enabled Date: Wed, 1 Apr 2020 15:32:38 -0400 Message-Id: <20200401193238.22544-1-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Initializing struct pages is a long task and keeping interrupts disabled for the duration of this operation introduces a number of problems. 1. jiffies are not updated for long period of time, and thus incorrect time is reported. See proposed solution and discussion here: lkml/20200311123848.118638-1-shile.zhang@linux.alibaba.com 2. It prevents farther improving deferred page initialization by allowing inter-node multi-threading. We are keeping interrupts disabled to solve a rather theoretical problem that was never observed in real world (See 3a2d7fa8a3d5). Lets keep interrupts enabled. In case we ever encounter a scenario where an interrupt thread wants to allocate large amount of memory this early in boot we can deal with that by growing zone (see deferred_grow_zone()) by the needed amount before starting deferred_init_memmap() threads. Before: [ 1.232459] node 0 initialised, 12058412 pages in 1ms After: [ 1.632580] node 0 initialised, 12051227 pages in 436ms Signed-off-by: Pavel Tatashin --- mm/page_alloc.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3c4eb750a199..4498a13b372d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1792,6 +1792,13 @@ static int __init deferred_init_memmap(void *data) BUG_ON(pgdat->first_deferred_pfn > pgdat_end_pfn(pgdat)); pgdat->first_deferred_pfn = ULONG_MAX; + /* + * Once we unlock here, the zone cannot be grown anymore, thus if an + * interrupt thread must allocate this early in boot, zone must be + * pre-grown prior to start of deferred page initialization. + */ + pgdat_resize_unlock(pgdat, &flags); + /* Only the highest zone is deferred so find it */ for (zid = 0; zid < MAX_NR_ZONES; zid++) { zone = pgdat->node_zones + zid; @@ -1812,8 +1819,6 @@ static int __init deferred_init_memmap(void *data) while (spfn < epfn) nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn); zone_empty: - pgdat_resize_unlock(pgdat, &flags); - /* Sanity check that the next zone really is unpopulated */ WARN_ON(++zid < MAX_NR_ZONES && populated_zone(++zone)); @@ -1854,18 +1859,6 @@ deferred_grow_zone(struct zone *zone, unsigned int order) return false; pgdat_resize_lock(pgdat, &flags); - - /* - * If deferred pages have been initialized while we were waiting for - * the lock, return true, as the zone was grown. The caller will retry - * this zone. We won't return to this function since the caller also - * has this static branch. - */ - if (!static_branch_unlikely(&deferred_pages)) { - pgdat_resize_unlock(pgdat, &flags); - return true; - } - /* * If someone grew this zone while we were waiting for spinlock, return * true, as there might be enough pages already. -- 2.17.1