From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D79A1C43331 for ; Wed, 1 Apr 2020 15:33:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C1412078C for ; Wed, 1 Apr 2020 15:33:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C1412078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B3538E0005; Wed, 1 Apr 2020 11:33:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 363B68E0001; Wed, 1 Apr 2020 11:33:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 279F58E0005; Wed, 1 Apr 2020 11:33:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 0CB728E0001 for ; Wed, 1 Apr 2020 11:33:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B5D62181AEF0B for ; Wed, 1 Apr 2020 15:33:27 +0000 (UTC) X-FDA: 76659680454.26.roll19_1e2e662531b5f X-HE-Tag: roll19_1e2e662531b5f X-Filterd-Recvd-Size: 3151 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 15:33:27 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id c7so569421wrx.5 for ; Wed, 01 Apr 2020 08:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gdjnfPiyLXeZ7G/kh5DpSiOaupsG2u3z0EOcxv3QzYE=; b=EovXYHW7cdiJyh3rZeKKwwqs6/MNdqxcwO5QmBgEz/tNKKqKL0r6gftHsYSYky32oZ IgE+iqrqo1ZVAFHhW1H8qKIyMIiXaSS1iyfSVumRWLkpQL4iF7/duIAFMQvQM43+MQbu S7Ojwx3plgCBHDykxteD3dsrmuuFtLXlM913Rv4t9q+zySQu8C2CfG/5a0zZ6XW9fLft dQF168BCgHo5Y25ANYco+2oEDcL1Y2Ez2ZCszEsara+A/Ymi505WZeMYlL0wNKNYUcm/ vsZwIbp7kYLAEqGCktErSbZLjGJiQ2e171sIyohNSCKhLPq4f0eFgptyczr8h+hv0nfU 9yHQ== X-Gm-Message-State: ANhLgQ2A2Rlg8ng910NOA9t4zlpPfDwgRlAEfQXuVfCYxGNfWn1/JW2V 2TkDUyvgTbrQIhbtf3egc0g= X-Google-Smtp-Source: ADFU+vv3tlENYaDpSey9RMPagQoSMJk9l6BD8L/TOufz2eXVKj2AOH0uJ5D1ncq9P1Z7f0u28UA1PA== X-Received: by 2002:adf:8187:: with SMTP id 7mr27717656wra.358.1585755206200; Wed, 01 Apr 2020 08:33:26 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id w9sm3465169wrk.18.2020.04.01.08.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 08:33:25 -0700 (PDT) Date: Wed, 1 Apr 2020 17:33:24 +0200 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan.c: use update_lru_size() in update_lru_sizes() Message-ID: <20200401153324.GP22681@dhcp22.suse.cz> References: <20200331221550.1011-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331221550.1011-1-richard.weiyang@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 31-03-20 22:15:50, Wei Yang wrote: > We already defined the helper update_lru_size(). > > Let's use this to reduce code duplication. > > Signed-off-by: Wei Yang Acked-by: Michal Hocko > --- > mm/vmscan.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f92858e5c2e3..a4fdf3dc8887 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec, > if (!nr_zone_taken[zid]) > continue; > > - __update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); > -#ifdef CONFIG_MEMCG > - mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); > -#endif > + update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); > } > > } > -- > 2.23.0 > -- Michal Hocko SUSE Labs