From: Michal Hocko <mhocko@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH] mm, trivial: Simplify swap related code in try_to_unmap_one()
Date: Wed, 1 Apr 2020 10:31:45 +0200 [thread overview]
Message-ID: <20200401083145.GF22681@dhcp22.suse.cz> (raw)
In-Reply-To: <87tv24j9hq.fsf@yhuang-dev.intel.com>
On Wed 01-04-20 09:11:13, Huang, Ying wrote:
[...]
> Then what is the check !PageSwapBacked() && PageSwapCache() for? To
> prevent someone to change the definition of PageSwapCache() in the
> future to break this?
Yes this is my understading. It is essentially an assert that enforces
the assumption about swap cache vs. swap backed being coupled.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-04-01 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 8:46 Huang, Ying
2020-03-31 9:41 ` Michal Hocko
2020-04-01 1:11 ` Huang, Ying
2020-04-01 8:31 ` Michal Hocko [this message]
2020-04-01 8:48 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401083145.GF22681@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@surriel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox