From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2359CC2D0EE for ; Tue, 31 Mar 2020 14:31:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E585A20848 for ; Tue, 31 Mar 2020 14:31:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E585A20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97BF86B0032; Tue, 31 Mar 2020 10:31:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92BA16B0037; Tue, 31 Mar 2020 10:31:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8422B6B0071; Tue, 31 Mar 2020 10:31:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 699F26B0032 for ; Tue, 31 Mar 2020 10:31:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 27AF6181AEF1D for ; Tue, 31 Mar 2020 14:31:41 +0000 (UTC) X-FDA: 76655896002.10.flesh96_e9c4c5b34307 X-HE-Tag: flesh96_e9c4c5b34307 X-Filterd-Recvd-Size: 4003 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 14:31:40 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id x7so10417535pgh.5 for ; Tue, 31 Mar 2020 07:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZV1KfwgGLtoEiy3TkAg/zZ6KIB+b40AZeOP0Q0XHWHU=; b=ImnjW7YSDzNGIaZr3UUqF/DYuIw87j4azYPagSYAPuFC2N3T4WVUxHOyeVQhHKa4o+ MAC0B/gOqmn4K/2hq7LhTanICEgSgOeIJhbzfd4OVFq4GZfPln36geeDmPN5C7JevQJJ Oo/vhueayWeouxBo6h8W3RmpVkXUGPuhNeU7uSQ4PnXogT6PTxEnpdrjxCoPfsSbFOl7 AXxTnM3UiOoF5wbjuE/9MXjSLmfFWSV8dacZfB9mmzJiHeJucsbMo1BFQDESiiA+R8h9 lCf7HqN7XW5KJTr1lK1xTu6U5lnnsBRodi7pbkRzrEQgv8xzVx3iPrqAc+hWqVcT13Wo ONrQ== X-Gm-Message-State: ANhLgQ3LRBCtPul5KG+0mXIyD+b4LMrPhXcBisrtWwUc/0ZIRw4aGGEq fCBs+KcWH6oKuKUtviBm2/5HocVewbw= X-Google-Smtp-Source: ADFU+vv9QG+JNLAPq5Hse2+XL1fqy/ETctrMBCrfQRW4WYOaoKGlkutwe7Dhv7pKCEUfjkAs3IExyg== X-Received: by 2002:a63:7e10:: with SMTP id z16mr18195431pgc.412.1585665098929; Tue, 31 Mar 2020 07:31:38 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 184sm469375pge.71.2020.03.31.07.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 07:31:35 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 0DA0940277; Tue, 31 Mar 2020 14:31:35 +0000 (UTC) Date: Tue, 31 Mar 2020 14:31:35 +0000 From: Luis Chamberlain To: Vlastimil Babka Cc: Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200331143134.GY11244@42.do-not-panic.com> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 31, 2020 at 09:42:46AM +0200, Vlastimil Babka wrote: > On 3/31/20 12:44 AM, Luis Chamberlain wrote: > > > > This is wonderful when we think about existing sysctls which have > > corresponding silly boot params that do the same thing. However, shoving > > a boot param capability down every possible built-in sysctl brings > > forward support considerations we should take serious, as this would > > add a new user interface and we'll have to support it. > > Hmm, if I boot with an initramfs with init process that does mount /proc and set > some sysctl there as the very first thing, then this will be almost the same > moment as my patch does it. There is no further kernel initialization in > between. So with your logic we already do support all non-modular sysctls to be > set so early. Yes, true. Then by all means: Reviewed-by: Luis Chamberlain Luis