From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E62C43331 for ; Tue, 31 Mar 2020 14:21:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 931312071A for ; Tue, 31 Mar 2020 14:21:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 931312071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27DFA6B0032; Tue, 31 Mar 2020 10:21:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2076D6B0037; Tue, 31 Mar 2020 10:21:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CFC86B006C; Tue, 31 Mar 2020 10:21:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id E44676B0032 for ; Tue, 31 Mar 2020 10:21:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AD6388248047 for ; Tue, 31 Mar 2020 14:21:42 +0000 (UTC) X-FDA: 76655870844.22.air42_491a06e18f03a X-HE-Tag: air42_491a06e18f03a X-Filterd-Recvd-Size: 7157 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 14:21:42 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id p10so26216344wrt.6 for ; Tue, 31 Mar 2020 07:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wqixz+ZIYAqgoA7MPWIYOpEEYP0CoNu6CnseEEi5hws=; b=WdZov0t67iJlvywj7yqYyXerf+/ekduPcnKAO1HErVw0PVsLDSsalr9IWtCsIfOIWf U2GB115oskemF4GGiaYa7aK0maFNlxY/tf6GG/zpeeNAf7mvomuqQqnVMCcnjOdj3m9/ bsAb/16NOiQxRADp6DJXRrUFEgMk0mcX5gzWcvXPCKRvmcfaMkvoNQZgsJaqxuam+VQo tJbx7akagYRhj1fODdRfNiAyM8xZn7ADk73AylaEDPtZSL7io2W9BYbQfSD3dPxwGlKZ Fse9bFbEA7gUhuUxrAwqdgX4PUAeBcuH3TLkIgPhR25iOgeo0AOKoJ6akhBz9naKwMSm Kg0w== X-Gm-Message-State: ANhLgQ2zcI/nM3L19GXLHrSprQfnPengGl4VDP914gplKrrgPg2XzDEf M/wOElPlXZSXioP6KJz5RfY= X-Google-Smtp-Source: ADFU+vuyE5SEZ+dPIFAcnIpCK+KoCMyMOpra8z4yVhIRJ2B/XSHZ5tSKeX1VNNnmQoYfW1esDx7ZTg== X-Received: by 2002:adf:eb0c:: with SMTP id s12mr20671936wrn.293.1585664500850; Tue, 31 Mar 2020 07:21:40 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id v7sm24508561wrs.96.2020.03.31.07.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 07:21:39 -0700 (PDT) Date: Tue, 31 Mar 2020 16:21:38 +0200 From: Michal Hocko To: Baoquan He Cc: Mike Rapoport , Hoan Tran , Catalin Marinas , Will Deacon , Andrew Morton , Vlastimil Babka , Oscar Salvador , Pavel Tatashin , Alexander Duyck , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "open list:MEMORY MANAGEMENT" , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, lho@amperecomputing.com, mmorana@amperecomputing.com Subject: Re: [PATCH v3 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-ID: <20200331142138.GL30449@dhcp22.suse.cz> References: <1585420282-25630-1-git-send-email-Hoan@os.amperecomputing.com> <20200330074246.GA14243@dhcp22.suse.cz> <20200330175100.GD30942@linux.ibm.com> <20200330182301.GM14243@dhcp22.suse.cz> <20200331081423.GE30942@linux.ibm.com> <20200331085513.GE30449@dhcp22.suse.cz> <20200331140332.GA2129@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331140332.GA2129@MiWiFi-R3L-srv> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 31-03-20 22:03:32, Baoquan He wrote: > Hi Michal, > > On 03/31/20 at 10:55am, Michal Hocko wrote: > > On Tue 31-03-20 11:14:23, Mike Rapoport wrote: > > > Maybe I mis-read the code, but I don't see how this could happen. In the > > > HAVE_MEMBLOCK_NODE_MAP=y case, free_area_init_node() calls > > > calculate_node_totalpages() that ensures that node->node_zones are entirely > > > within the node because this is checked in zone_spanned_pages_in_node(). > > > > zone_spanned_pages_in_node does chech the zone boundaries are within the > > node boundaries. But that doesn't really tell anything about other > > potential zones interleaving with the physical memory range. > > zone->spanned_pages simply gives the physical range for the zone > > including holes. Interleaving nodes are essentially a hole > > (__absent_pages_in_range is going to skip those). > > > > That means that when free_area_init_core simply goes over the whole > > physical zone range including holes and that is why we need to check > > both for physical and logical holes (aka other nodes). > > > > The life would be so much easier if the whole thing would simply iterate > > over memblocks... > > The memblock iterating sounds a great idea. I tried with putting the > memblock iterating in the upper layer, memmap_init(), which is used for > boot mem only anyway. Do you think it's doable and OK? It yes, I can > work out a formal patch to make this simpler as you said. The draft code > is as below. Like this it uses the existing code and involves little change. Doing this would be a step in the right direction! I haven't checked the code very closely though. The below sounds way too simple to be truth I am afraid. First for_each_mem_pfn_range is available only for CONFIG_HAVE_MEMBLOCK_NODE_MAP (which is one of the reasons why I keep saying that I really hate that being conditional). Also I haven't really checked the deferred initialization path - I have a very vague recollection that it has been converted to the memblock api but I have happilly dropped all that memory. > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 138a56c0f48f..558d421f294b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6007,14 +6007,6 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone, > * function. They do not exist on hotplugged memory. > */ > if (context == MEMMAP_EARLY) { > - if (!early_pfn_valid(pfn)) { > - pfn = next_pfn(pfn); > - continue; > - } > - if (!early_pfn_in_nid(pfn, nid)) { > - pfn++; > - continue; > - } > if (overlap_memmap_init(zone, &pfn)) > continue; > if (defer_init(nid, pfn, end_pfn)) > @@ -6130,9 +6122,17 @@ static void __meminit zone_init_free_lists(struct zone *zone) > } > > void __meminit __weak memmap_init(unsigned long size, int nid, > - unsigned long zone, unsigned long start_pfn) > + unsigned long zone, unsigned long range_start_pfn) > { > - memmap_init_zone(size, nid, zone, start_pfn, MEMMAP_EARLY, NULL); > + unsigned long start_pfn, end_pfn; > + unsigned long range_end_pfn = range_start_pfn + size; > + int i; > + for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) { > + start_pfn = clamp(start_pfn, range_start_pfn, range_end_pfn); > + end_pfn = clamp(end_pfn, range_start_pfn, range_end_pfn); > + if (end_pfn > start_pfn) > + memmap_init_zone(size, nid, zone, start_pfn, MEMMAP_EARLY, NULL); > + } > } > > static int zone_batchsize(struct zone *zone) -- Michal Hocko SUSE Labs