From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C2CC2D0F0 for ; Tue, 31 Mar 2020 14:04:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BC5F20848 for ; Tue, 31 Mar 2020 14:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xt8ZOLs/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC5F20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EE796B0037; Tue, 31 Mar 2020 10:04:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19F0C6B006C; Tue, 31 Mar 2020 10:04:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B4F06B006E; Tue, 31 Mar 2020 10:04:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id E9C886B0037 for ; Tue, 31 Mar 2020 10:04:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8FB07824805A for ; Tue, 31 Mar 2020 14:04:43 +0000 (UTC) X-FDA: 76655828046.24.hat99_464a3c68f9f27 X-HE-Tag: hat99_464a3c68f9f27 X-Filterd-Recvd-Size: 5889 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 14:04:42 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id f20so22136882ljm.0 for ; Tue, 31 Mar 2020 07:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MDdUt2Xx7CsJa6khvoaGnC8v0ElEvPxQibVr3Q0lyA0=; b=Xt8ZOLs/9+oLndJW2LeyLzmXHPe+a5ZaO7yuXusrKEEooFZqJk0SHV3D5NA3A0tuof Kuj/fghd8kbgdHaUOc23KMYkypOLAU8gB6NyPHUFgg6SCPgGUmTbACI/mMMaDR7SOmfG frE/wPklAnN/5IRz2rVDhBP/aSR25XIMr6DXr+Byi8O6Py3p5icVgGmRDJSAxIknYxVj aOntTMQKGKCBLPwY3RRzXo1PD1vykgic5clRiQESmlZro7NwH4Uynitkua8q3blTXTku kdVz+AHtttOrqkhXiSxnccwW44LMKSbPqguxWFkiWVRjtlmnHMQxbyjHuLkHxI8uFVRV 0nyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MDdUt2Xx7CsJa6khvoaGnC8v0ElEvPxQibVr3Q0lyA0=; b=rKAw2CGHfsoUdUQPLfR1w7BmT8/vzlYbCJhyM57GABSJQ6yvGTA/ORUltxmpgji8Um VHQpfYWAkd5gjHmvIv2w2VcdTbYnAnGY3TeFKQkpPgVLnRHb9Wh/F6HBRkKOTxbexUTO acppw11qaCd6hiefDrEah7hNHs/qNMcMuXpb0Atpa1pdrsI5Ej0QqdrbBaVH4C9mqH/d DSYZ1+/edxIPxse3m9OWMaikTTo0gcs31G/NjJWDpo5svX6JH1kJd/xkH+ifAA6YSp6/ V1Co59wFSkim2Or1tF2ak9caw0to/GePToVCdUfrQI2GfNbBtLt+a5biMdCbCAIZnyjJ nh4A== X-Gm-Message-State: AGi0PuYt+BQmZvPPvuEen31ihczH8j8T8w0AC66RXUyJ2CtQ6Moi/EU7 FRT6S+LIQWHBYYB6K6ksEVQ= X-Google-Smtp-Source: APiQypI4fAWKLnARPHwBzr7LMf8/4/VuGvwrht4oSGSknhX+lU0YSToDfvpjMh2o1Loq9tzpRQlO0A== X-Received: by 2002:a05:651c:1102:: with SMTP id d2mr10524529ljo.102.1585663481281; Tue, 31 Mar 2020 07:04:41 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id j125sm8678528lfj.38.2020.03.31.07.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 07:04:40 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 31 Mar 2020 16:04:33 +0200 To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rcu@vger.kernel.org, willy@infradead.org, peterz@infradead.org, neilb@suse.com, vbabka@suse.cz, mgorman@suse.de, Andrew Morton , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , "Paul E. McKenney" , Steven Rostedt Subject: Re: [PATCH RFC] rcu/tree: Use GFP_MEMALLOC for alloc memory to free memory pattern Message-ID: <20200331140433.GA26498@pc636> References: <20200331131628.153118-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331131628.153118-1-joel@joelfernandes.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 31, 2020 at 09:16:28AM -0400, Joel Fernandes (Google) wrote: > In kfree_rcu() headless implementation (where the caller need not pass > an rcu_head, but rather directly pass a pointer to an object), we have > a fall-back where we allocate a rcu_head wrapper for the caller (not the > common case). This brings the pattern of needing to allocate some memory > to free some memory. Currently we use GFP_ATOMIC flag to try harder for > this allocation, however the GFP_MEMALLOC flag is more tailored to this > pattern. We need to try harder not only during atomic context, but also > during non-atomic context anyway. So use the GFP_MEMALLOC flag instead. > > Also remove the __GFP_NOWARN flag simply because although we do have a > synchronize_rcu() fallback for absolutely worst case, we still would > like to not enter that path and atleast trigger a warning to the user. > > Cc: linux-mm@kvack.org > Cc: rcu@vger.kernel.org > Cc: willy@infradead.org > Cc: peterz@infradead.org > Cc: neilb@suse.com > Cc: vbabka@suse.cz > Cc: mgorman@suse.de > Cc: Andrew Morton > Signed-off-by: Joel Fernandes (Google) > --- > > This patch is based on the (not yet upstream) code in: > git://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git (branch rcu/kfree) > > It is a follow-up to the posted series: > https://lore.kernel.org/lkml/20200330023248.164994-1-joel@joelfernandes.org/ > > > kernel/rcu/tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 4be763355c9fb..965deefffdd58 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3149,7 +3149,7 @@ static inline struct rcu_head *attach_rcu_head_to_object(void *obj) > > if (!ptr) > ptr = kmalloc(sizeof(unsigned long *) + > - sizeof(struct rcu_head), GFP_ATOMIC | __GFP_NOWARN); > + sizeof(struct rcu_head), GFP_MEMALLOC); > Hello, Joel I have some questions regarding improving it, see below them: Do you mean __GFP_MEMALLOC? Can that flag be used in atomic context? Actually we do allocate there under spin lock. Should be combined with GFP_ATOMIC | __GFP_MEMALLOC? As for removing __GFP_NOWARN. Actually it is expectable that an allocation can fail, if so we follow last emergency case. You can see the trace but what would you do with that information? Thanks! -- Vlad Rezki