From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAB3C2D0EF for ; Tue, 31 Mar 2020 07:48:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFD66206F5 for ; Tue, 31 Mar 2020 07:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFD66206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C4546B0032; Tue, 31 Mar 2020 03:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74DB06B0037; Tue, 31 Mar 2020 03:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 614D46B006C; Tue, 31 Mar 2020 03:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 4601D6B0032 for ; Tue, 31 Mar 2020 03:48:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 058D6180AD80F for ; Tue, 31 Mar 2020 07:48:41 +0000 (UTC) X-FDA: 76654880442.22.card55_85fd8eac74f24 X-HE-Tag: card55_85fd8eac74f24 X-Filterd-Recvd-Size: 3465 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 07:48:40 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id j17so24548291wru.13 for ; Tue, 31 Mar 2020 00:48:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sDDR7wkznk3Ln/XEBAe1hdquHTqCjRL2OUXoeHhs1/I=; b=ON6XWyn8S61Lj88k0BrwUAtl02FM1Vtui7QvWqZzbwGmbljS1dW5yoaViTIXqiP2B7 XfaZscGRklQPRJrSuROvMkTBuIsuB2Y+wkCZPkjhXaDeiHNeib4n8QsqekJzsjMqUSjO sP2jLkxdkMqpJuxNP5WJbYGA3+0U07CWfBQZikzbbepC9XTlkgrn3gVa9LljCpBIowP8 VYs+yzmEMgMiXYZJBPIkJGTjPfa5KomtBLf6ciaIwDjI/U2cfcfmlsYu+PyhNDEEHeJP mWqkJA/87i0LNQuaglS3Qv1gvP6+dOeuWK1fS3yUtbWxycj32KMWYDLRk+T74HeztqRr 4hbg== X-Gm-Message-State: ANhLgQ0rsrSWXqu+gEgNmVlQNO8tDnR/5r36iwN7MKCnYAVYUmlZwAFF tQWUwRpOX1//HcgbsMujBxs= X-Google-Smtp-Source: ADFU+vv3EXliVsMAUSV9EjxsWTfTwAunV64IBIwQFULkiEChbiWPpqyxtb84adDetxoemQODGsJkDA== X-Received: by 2002:adf:e90b:: with SMTP id f11mr6877457wrm.65.1585640919502; Tue, 31 Mar 2020 00:48:39 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id t81sm2728726wmb.15.2020.03.31.00.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 00:48:37 -0700 (PDT) Date: Tue, 31 Mar 2020 09:48:36 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200331074836.GB30449@dhcp22.suse.cz> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 31-03-20 09:42:46, Vlastimil Babka wrote: [...] > > Should we not do this, we'll have to live with the consequences of > > supporting the full swoop of sysctls are boot params, whatever > > consequences those may be. > > Of course when the first user tries to set some particular sysctl as boot param > and finds and reports it doesn't work as intended, then it can be fixed or > blacklisted and it can't break anyone else? Absolutely agreed. I would be really careful to not overengineer this whole thing. -- Michal Hocko SUSE Labs