From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF8AC43331 for ; Mon, 30 Mar 2020 18:23:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64266206F6 for ; Mon, 30 Mar 2020 18:23:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64266206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 16D056B000C; Mon, 30 Mar 2020 14:23:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 146038E0001; Mon, 30 Mar 2020 14:23:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 059B96B0037; Mon, 30 Mar 2020 14:23:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id E2EAF6B000C for ; Mon, 30 Mar 2020 14:23:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8F894181AD0A6 for ; Mon, 30 Mar 2020 18:23:04 +0000 (UTC) X-FDA: 76652850288.02.cake56_5506fb3604133 X-HE-Tag: cake56_5506fb3604133 X-Filterd-Recvd-Size: 6162 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 18:23:04 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id h15so22872641wrx.9 for ; Mon, 30 Mar 2020 11:23:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0jhRFYVkza+qJU3Il8/iXGVhPGBzX8dkXPD9i1bwSag=; b=I4fVlH7OmcP76utMKsoPBh0PBveGnSDLP6wd3KXJl1gSoAe9rle6hLMUeEFQ9f0EZI zPiya/AGHzLB4FRgUJn0dcEhhDIKYFS/daNx8WMbpgJ61n5vnUwuh1JVNmHwP3o4Wt59 Jzt6jHYtZ4U10fTzkWVBJImk2OXTXVIdvuxu4E338kvl+g2xNEqLN6obHhEt3gOCBxv3 caIzY6uu4j4SfrGyDxzqQXEZpOLvYyXYzB2HRlGiG2ic+8M4qv7CU4B54tstkqVbcjQX L4Yiv0vTL9P0bIX4u8Ek2P5tE1DyGFWpgsQYsqvH0g3QrenWnMBzJfagbtFZRFGKDFA2 7mhQ== X-Gm-Message-State: ANhLgQ1iWlpEv/4s50N8xgyI0xdSkvPPHddYlboy2BuwZPEMQ8x94RWr aesjXRvOZue80Y/xdmDodIE= X-Google-Smtp-Source: ADFU+vv5K/FBYjKeTVX0F/L19lDVfm50dWVM5MaRN4MeyMqOqGnWTdxnNM7cmfvlZTzDum9SAd0OPg== X-Received: by 2002:adf:d849:: with SMTP id k9mr15996160wrl.108.1585592583199; Mon, 30 Mar 2020 11:23:03 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id f187sm474696wme.9.2020.03.30.11.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 11:23:02 -0700 (PDT) Date: Mon, 30 Mar 2020 20:23:01 +0200 From: Michal Hocko To: Mike Rapoport Cc: Hoan Tran , Catalin Marinas , Will Deacon , Andrew Morton , Vlastimil Babka , Oscar Salvador , Pavel Tatashin , Alexander Duyck , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "open list:MEMORY MANAGEMENT" , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, lho@amperecomputing.com, mmorana@amperecomputing.com Subject: Re: [PATCH v3 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-ID: <20200330182301.GM14243@dhcp22.suse.cz> References: <1585420282-25630-1-git-send-email-Hoan@os.amperecomputing.com> <20200330074246.GA14243@dhcp22.suse.cz> <20200330175100.GD30942@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330175100.GD30942@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 30-03-20 20:51:00, Mike Rapoport wrote: > On Mon, Mar 30, 2020 at 09:42:46AM +0200, Michal Hocko wrote: > > On Sat 28-03-20 11:31:17, Hoan Tran wrote: > > > In NUMA layout which nodes have memory ranges that span across other nodes, > > > the mm driver can detect the memory node id incorrectly. > > > > > > For example, with layout below > > > Node 0 address: 0000 xxxx 0000 xxxx > > > Node 1 address: xxxx 1111 xxxx 1111 > > > > > > Note: > > > - Memory from low to high > > > - 0/1: Node id > > > - x: Invalid memory of a node > > > > > > When mm probes the memory map, without CONFIG_NODES_SPAN_OTHER_NODES > > > config, mm only checks the memory validity but not the node id. > > > Because of that, Node 1 also detects the memory from node 0 as below > > > when it scans from the start address to the end address of node 1. > > > > > > Node 0 address: 0000 xxxx xxxx xxxx > > > Node 1 address: xxxx 1111 1111 1111 > > > > > > This layout could occur on any architecture. Most of them enables > > > this config by default with CONFIG_NUMA. This patch, by default, enables > > > CONFIG_NODES_SPAN_OTHER_NODES or uses early_pfn_in_nid() for NUMA. > > > > I am not opposed to this at all. It reduces the config space and that is > > a good thing on its own. The history has shown that meory layout might > > be really wild wrt NUMA. The config is only used for early_pfn_in_nid > > which is clearly an overkill. > > > > Your description doesn't really explain why this is safe though. The > > history of this config is somehow messy, though. Mike has tried > > to remove it a94b3ab7eab4 ("[PATCH] mm: remove arch independent > > NODES_SPAN_OTHER_NODES") just to be reintroduced by 7516795739bd > > ("[PATCH] Reintroduce NODES_SPAN_OTHER_NODES for powerpc") without any > > reasoning what so ever. This doesn't make it really easy see whether > > reasons for reintroduction are still there. Maybe there are some subtle > > dependencies. I do not see any TBH but that might be burried deep in an > > arch specific code. > > I've looked at this a bit more and it seems that the check for > early_pfn_in_nid() in memmap_init_zone() can be simply removed. > > The commits you've mentioned were way before the addition of > HAVE_MEMBLOCK_NODE_MAP and the whole infrastructure that calculates zone > sizes and boundaries based on the memblock node map. > So, the memmap_init_zone() is called when zone boundaries are already > within a node. But zones from different nodes might overlap in the pfn range. And this check is there to skip over those overlapping areas. The only way to skip over this check I can see is to do a different pfn walk and go through memblock ranges which are guaranteed to belong to a single node. -- Michal Hocko SUSE Labs