From: George Spelvin <lkml@SDF.ORG>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Atul Gupta <atul.gupta@chelsio.com>,
linux-crypto@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Potnuri Bharat Teja <bharat@chelsio.com>,
linux-rdma@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
linux-mtd@lists.infradead.org, netdev@vger.kernel.org,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, Kalle Valo <kvalo@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
linux-wireless@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
QLogic-Storage-Upstream@cavium.com, linux-scsi@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, Jan Kara <jack@suse.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
Sven Eckelmann <sven@narfation.org>,
b.a.t.m.a.n@diktynna.open-mesh.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Stephen Hemminger <stephen@networkplumber.org>,
netem@lists.linux-foundation.org,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
linux-sctp@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, Jon Maloy <jon.maloy@ericsson.com>,
Ying Xue <ying.xue@windriver.com>,
tipc-discussion@lists.sourceforge.net,
Steffen Klassert <steffen.klassert@secunet.com>,
lkml@sdf.org
Subject: Re: [RFC PATCH v1 11/50] Treewide: Extirpate "prandom_u32() % range"
Date: Mon, 30 Mar 2020 17:03:21 +0000 [thread overview]
Message-ID: <20200330170321.GC2459@SDF.ORG> (raw)
In-Reply-To: <20200330133331.GB26544@quack2.suse.cz>
On Mon, Mar 30, 2020 at 03:33:31PM +0200, Jan Kara wrote:
> Honestly, I think that a microoptimization like this will bring any benefit
> only in the fast paths and e.g. most of the filesystem places aren't like
> that as far as I've checked. OTOH it doesn't hurt readability so I'm not
> opposed either. So feel free to add:
>
> Acked-by: Jan Kara <jack@suse.cz>
>
> for ext2 and ext4 bits.
Thank you!
I fully agree with you, but
- Figuring out whether a particular site is a fast path or not is a lot
more work than simply fixing it,
- It's also smaller, which is what we care about for slow-path code. and
- I wish people would stop copying the slow code to fast paths.
If I make sure the kernel is full of good examples and devoid of
bad examples, the odds improve.
prev parent reply other threads:[~2020-03-30 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202003281643.02SGhAN9009531@sdf.org>
2020-03-30 13:33 ` Jan Kara
2020-03-30 17:03 ` George Spelvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330170321.GC2459@SDF.ORG \
--to=lkml@sdf.org \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=a@unstable.cc \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atul.gupta@chelsio.com \
--cc=b.a.t.m.a.n@diktynna.open-mesh.org \
--cc=bfields@fieldses.org \
--cc=bharat@chelsio.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chi-hsien.lin@cypress.com \
--cc=chuck.lever@oracle.com \
--cc=computersforpeace@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=dledford@redhat.com \
--cc=dwmw2@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hare@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=jlayton@kernel.org \
--cc=johannes.berg@intel.com \
--cc=jon.maloy@ericsson.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=mareklindner@neomailbox.ch \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=netem@lists.linux-foundation.org \
--cc=nhorman@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=sage@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=trond.myklebust@hammerspace.com \
--cc=tytso@mit.edu \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vyasevich@gmail.com \
--cc=wright.feng@cypress.com \
--cc=xiyou.wangcong@gmail.com \
--cc=ying.xue@windriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox