From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13212C2D0E9 for ; Mon, 30 Mar 2020 08:43:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D60F82073B for ; Mon, 30 Mar 2020 08:43:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60F82073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 718D56B0008; Mon, 30 Mar 2020 04:43:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9476B000C; Mon, 30 Mar 2020 04:43:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DF986B0032; Mon, 30 Mar 2020 04:43:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4410C6B0008 for ; Mon, 30 Mar 2020 04:43:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DF520441C for ; Mon, 30 Mar 2020 08:43:05 +0000 (UTC) X-FDA: 76651388730.03.skirt79_7253b2edbab27 X-HE-Tag: skirt79_7253b2edbab27 X-Filterd-Recvd-Size: 3550 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 08:43:05 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id e9so8972204wme.4 for ; Mon, 30 Mar 2020 01:43:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ocjz0JW0NGqrN1N1HQX6Y1TDgGsqONxhflCXz8O8z9s=; b=DtHp/uPhp9ajTd+/P9YGjWIPvPUQAtv+SFshTQuDLqTfkEQ1paTSyhGYFw6LspQONm wcIqQZG3kwCeoSbl2+LxZFlvwMfnfwJa2l3hUqwx54jYRQEkSWDIF4JJpHtoK6ngJKCL ecEfUIU0UmMA4cLBY0YPf443SFQGOmGybqlSE9PdmbhxIsAHLZh5Yrfl04zcaFxnxcWc kfsi3mus4CnCzXBpN46HIiJgjCaasSkREGZK6dgSLK7izRTUeVnVu/Upc1e0CYbBezqA r52vkE7YbpjAAaqKtqS0VsOVFNeswfAQfaXTcOHPaYbYLJ+3R6kS7gRVdyIL7AD7pnQI 8pFQ== X-Gm-Message-State: ANhLgQ1j0q7DA4bPIwq8a5286eBvr1G3yGllkQ4Z0wOLQJ/5MVsP28bT INBAj7bHSIiD29XUsdLzxJA= X-Google-Smtp-Source: ADFU+vvSsbizGL71GziNxkHgDWksgMBhdi++vDZxuGiIBC+Bc9WUTwsqevNE0FbnjwELwApmuFKUnw== X-Received: by 2002:a7b:c14d:: with SMTP id z13mr11662455wmi.94.1585557784407; Mon, 30 Mar 2020 01:43:04 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id c18sm21397292wrx.5.2020.03.30.01.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 01:43:03 -0700 (PDT) Date: Mon, 30 Mar 2020 10:43:00 +0200 From: Michal Hocko To: Anshuman Khandual Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org Subject: Re: [RFC] mm/page_alloc: Enumerate bad page reasons Message-ID: <20200330084300.GC14243@dhcp22.suse.cz> References: <1585551097-27283-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585551097-27283-1-git-send-email-anshuman.khandual@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 30-03-20 12:21:37, Anshuman Khandual wrote: > Enumerate all existing bad page reasons which can be used in bad_page() for > reporting via __dump_page(). Unfortunately __dump_page() cannot be changed. > __dump_page() is called from dump_page() that accepts a raw string and is > also an exported symbol that is currently being used from various generic > memory functions and other drivers. This reduces code duplication while > reporting bad pages. I dunno. It sounds like over engineering something that is an internal stuff. Besides that I consider string reasons kinda obvious and I am pretty sure I would have to check them for each numeric alias when want to read the code. Yeah, yeah, nothing really hard but still... So I am not really sure this is all worth the code churn. Besides that I stongly suspect you wanted ... > -static void bad_page(struct page *page, const char *reason, > +static void bad_page(struct page *page, int reason, > unsigned long bad_flags) ... enum page_bad_reason reason here, right? What is the point of declaring an enum when you are not using it? -- Michal Hocko SUSE Labs