From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26958C43331 for ; Sat, 28 Mar 2020 12:18:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5AAC206F6 for ; Sat, 28 Mar 2020 12:18:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="t57oPtPy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5AAC206F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CF8F6B0010; Sat, 28 Mar 2020 08:18:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65A676B0032; Sat, 28 Mar 2020 08:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 521D86B0036; Sat, 28 Mar 2020 08:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 355F46B0010 for ; Sat, 28 Mar 2020 08:18:29 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AA9B78248068 for ; Sat, 28 Mar 2020 12:18:28 +0000 (UTC) X-FDA: 76644673896.06.veil95_842df44786c3c X-HE-Tag: veil95_842df44786c3c X-Filterd-Recvd-Size: 4918 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Mar 2020 12:18:28 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id g12so12984848ljj.3 for ; Sat, 28 Mar 2020 05:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DLgjRkbqkZXUrHTSAMZJhzjxeF+WpWX9n+s+f97+oHU=; b=t57oPtPyEDn94rGhZYNo/2+yHohX/cUM4XQOYORvnWvJyUH6F/Rdr1Oxv+VfAjkku+ +8hZ4qXHGdice8U2dY/9xU9EHDjISIUbbXFgfDtDT/NQrdAP+VIeoCJWBRtlpbSlzeKV FSz6/yzF8aQ7Z9DJcbpeX4rdT0ckxUEKyJBK2YA5FdwmC7AlVWO2ZjlLaLJCJbZiLt47 CyJZIKdoSnrU8dzPykoyfaWarI105Q5LBGve13meRT2YyCOPxnCHBaQ3yZbGwFNSneVX IZ5uF3kADFDLwBckXZ4ZPS6EjE+Aj4BX5qIEFhbZb6Ld1I7rlgy6LVlw/TARQ4ckYTm2 3DYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DLgjRkbqkZXUrHTSAMZJhzjxeF+WpWX9n+s+f97+oHU=; b=lnzlviBETMQ+kTUUPW/3IG9RafNSHXN5WsYOZgA2SvgRc/Ddw6cBeO916kpPFne6OG nibaKwYHyq4VKnPMp95OoWo2+xTOhg+rhx/nv/VRutwH9nJYLccU7APLwN5IwLR1lomr HkrTrpgV3dcu9nk845o78HaGIZUpfMGq2pw//bxEfg5SsZL+ANa2xz6xE80bffJA5NAY VvHNDwdersx/9RY62frYc6bgze3hitYN/B2ebu6AE3ljlzjVMubH39Km0g28TsiYMGSW SjshaMPU1DnI2XzoKSKpPQRE9j4vWWzYZ8tV+to+KreOaA7caJCG7jjAqnjWHqskhPe8 6EZA== X-Gm-Message-State: AGi0PuZS3maXUv9lPMa2aVDOROyh8wqz45l2hRPUasldrTT1Dmdgph/L Gafdy0YUPU7k0QNCda53eY/gbA== X-Google-Smtp-Source: APiQypLRBIt23Mve8TSr7DgnTEuywVLE62QgLty8d3VrixDm9zomvZg4gf5EvRTzi6HE4Bnliiegrg== X-Received: by 2002:a2e:8109:: with SMTP id d9mr2148319ljg.31.1585397906879; Sat, 28 Mar 2020 05:18:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id f23sm177168lja.60.2020.03.28.05.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2020 05:18:26 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id A1335100D25; Sat, 28 Mar 2020 15:18:29 +0300 (+03) Date: Sat, 28 Mar 2020 15:18:29 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: Andrew Morton , Andrea Arcangeli , Linux MM , Linux Kernel Mailing List , "Kirill A. Shutemov" Subject: Re: [PATCH 3/7] khugepaged: Drain LRU add pagevec to get rid of extra pins Message-ID: <20200328121829.kzmcmcshbwynjmqc@box> References: <20200327170601.18563-1-kirill.shutemov@linux.intel.com> <20200327170601.18563-4-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 27, 2020 at 11:10:40AM -0700, Yang Shi wrote: > On Fri, Mar 27, 2020 at 10:06 AM Kirill A. Shutemov > wrote: > > > > __collapse_huge_page_isolate() may fail due to extra pin in the LRU add > > pagevec. It's petty common for swapin case: we swap in pages just to > > fail due to the extra pin. > > > > Signed-off-by: Kirill A. Shutemov > > --- > > mm/khugepaged.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 14d7afc90786..39e0994abeb8 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -585,11 +585,19 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > > * The page must only be referenced by the scanned process > > * and page swap cache. > > */ > > + if (page_count(page) != 1 + PageSwapCache(page)) { > > + /* > > + * Drain pagevec and retry just in case we can get rid > > + * of the extra pin, like in swapin case. > > + */ > > + lru_add_drain(); > > This is definitely correct. > > I'm wondering if we need one more lru_add_drain() before PageLRU check > in khugepaged_scan_pmd() or not? The page might be in lru cache then > get skipped. This would improve the success rate. Could you elaborate on the scenario, I don't follow. -- Kirill A. Shutemov