From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Zi Yan <ziy@nvidia.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] thp: Simplify splitting PMD mapping huge zero page
Date: Sat, 28 Mar 2020 03:19:59 +0300 [thread overview]
Message-ID: <20200328001959.ggi74gch42soulus@box> (raw)
In-Reply-To: <1437F525-1510-45CD-A67F-13DF525083B4@nvidia.com>
On Fri, Mar 27, 2020 at 01:23:07PM -0400, Zi Yan wrote:
> On 27 Mar 2020, at 13:03, Kirill A. Shutemov wrote:
>
> > Splitting PMD mapping huge zero page can be simplified a lot: we can
> > just unmap it and fallback to PTE handling.
>
> So we will have an extra page fault for the first read to each subpage,
> but nothing changes if the first access to a subpage is a write, right?
> BTW, what is the motivation for this code simplification?
Match what we do for file-THP.
I found a problem with the patch. Ignore it for now.
--
Kirill A. Shutemov
prev parent reply other threads:[~2020-03-28 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 17:03 Kirill A. Shutemov
2020-03-27 17:23 ` Zi Yan
2020-03-28 0:19 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328001959.ggi74gch42soulus@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox