From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, david@redhat.com
Subject: Re: [Patch v2 2/2] mm/page_alloc.c: define node_order with all zero
Date: Fri, 27 Mar 2020 20:18:20 -0300 [thread overview]
Message-ID: <20200327231820.GA20941@ziepe.ca> (raw)
In-Reply-To: <4c9d8138-d379-810f-64e7-0d018ed019df@nvidia.com>
On Fri, Mar 27, 2020 at 03:37:57PM -0700, John Hubbard wrote:
> On 3/27/20 3:01 PM, Wei Yang wrote:
> > Since we always clear node_order before getting it, we can leverage
> > compiler to do this instead of at run time.
> >
> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> > mm/page_alloc.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index dfcf2682ed40..49dd1f25c000 100644
> > +++ b/mm/page_alloc.c
> > @@ -5585,7 +5585,7 @@ static void build_thisnode_zonelists(pg_data_t *pgdat)
> > static void build_zonelists(pg_data_t *pgdat)
> > {
> > - static int node_order[MAX_NUMNODES];
> > + static int node_order[MAX_NUMNODES] = {0};
>
>
> Looks wrong: now the single instance of node_order is initialized just once by
> the compiler. And that means that only the first caller of this function
> gets a zeroed node_order array...
It is also redundant, all static data is 0 initialized in Linux and
should not be explicitly initialized so it can remain in .bss
> > @@ -5595,7 +5595,6 @@ static void build_zonelists(pg_data_t *pgdat)
> > load = nr_online_nodes;
> > prev_node = local_node;
> > - memset(node_order, 0, sizeof(node_order));
>
> ...and all subsequent callers are left with whatever debris is remaining in
> node_order. So this is not good.
Indeed
Jason
next prev parent reply other threads:[~2020-03-27 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:01 [Patch v2 1/2] mm/page_alloc.c: use NODE_MASK_NONE define used_mask Wei Yang
2020-03-27 22:01 ` [Patch v2 2/2] mm/page_alloc.c: define node_order with all zero Wei Yang
2020-03-27 22:37 ` John Hubbard
2020-03-27 23:18 ` Jason Gunthorpe [this message]
2020-03-28 0:27 ` Wei Yang
2020-03-28 0:26 ` Wei Yang
2020-03-28 0:51 ` Baoquan He
2020-03-28 0:59 ` John Hubbard
2020-03-28 1:10 ` Wei Yang
2020-03-28 1:28 ` John Hubbard
2020-03-28 2:56 ` Wei Yang
2020-03-29 1:30 ` John Hubbard
2020-03-29 2:31 ` Wei Yang
2020-03-28 11:25 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327231820.GA20941@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox