From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17C1C43331 for ; Fri, 27 Mar 2020 13:27:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C1092082D for ; Fri, 27 Mar 2020 13:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iZo3Z5/h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C1092082D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E57536B0010; Fri, 27 Mar 2020 09:27:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E08CA6B0032; Fri, 27 Mar 2020 09:27:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44CA6B0036; Fri, 27 Mar 2020 09:27:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id BD63C6B0010 for ; Fri, 27 Mar 2020 09:27:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 99DFB180AD80F for ; Fri, 27 Mar 2020 13:27:25 +0000 (UTC) X-FDA: 76641218850.06.ink05_5de74da1cea25 X-HE-Tag: ink05_5de74da1cea25 X-Filterd-Recvd-Size: 4156 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 13:27:25 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id m17so11344824wrw.11 for ; Fri, 27 Mar 2020 06:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MiukankS2d7HoYog4uANLr+kARZRnzMZU2xCKuAVLzw=; b=iZo3Z5/hPxxnQ4EWWx1JJmhNk3kYv8xKiaps4ep//w5VyMNqVTuh9PiCjiYvewDmr8 6VWBPsBnNplJbLo/E1nQlQr1VoY6ciX7nxmQ7ml6NNZ6AQFEeTa6c064Hz+uQBkMxIYb wXDJmgh3VB+RmSAHHnDcOHpSMifXRhmaraoK5USGFBHzIQSMwytoEKO3pC0+NhpHsSQj Poh0JDNIB7VKR27DgAuTneNIVNcbC48+wt4FILzJRgYgTlXJoyOrQpnKqqxSSiM40xgW rE/07Esi5tND2/aO3nbkV9omsfklgvrJjI7zPSC9wfb5tpNFqwNldOqwOWMGaRjIDCWj 5+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=MiukankS2d7HoYog4uANLr+kARZRnzMZU2xCKuAVLzw=; b=mpVlpb+ZQRP3LIvpgkmqa2VM+YL4kAhD0STuUQ+OBuNsGzZUTulHN/2lDeOxH+jQMl zUc+hLbSpGvtwnCd7ySj4jj+rzpTgB+MVue5PErrPjqj0UBDajybEWdilFhdQzQxKOAD WpE9s1QM0yPvJVBjsfGJCqoRegfk6nUOK9TBBFxgldO0YWaye92EksGEeEctJOvnRmuL g6bg5z6TQr3rJg5SvAcPSOf3Z1KCDVhtRpJ5hIkhYy0gpHki/1UuvVDOOzKabd9bZSkR nzNPo+vWJRWE4F/fK3NuZMDAdiGS7K7Apt7U1HxU6SyvAE+136Ei2Yu07KqZgO+81qsn ZSnw== X-Gm-Message-State: ANhLgQ3jCMSMgzVp81cfUkZv6qfO1FrdNVhYwIxESJfC6JWgzTHvNYcO VaurpNx5kjburH7CpN9tdoU= X-Google-Smtp-Source: ADFU+vsnYsTAqeHpcm8tqBofCqi4JBfOXJF5rVRfuLS7F1WUtlA/PE3zXOxs67WjpxoJNi1u4gmHaQ== X-Received: by 2002:adf:f1ce:: with SMTP id z14mr15194886wro.68.1585315643876; Fri, 27 Mar 2020 06:27:23 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id y16sm8334328wrp.78.2020.03.27.06.27.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 06:27:23 -0700 (PDT) Date: Fri, 27 Mar 2020 13:27:22 +0000 From: Wei Yang To: Jason Gunthorpe Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask Message-ID: <20200327132722.rovaz5hghl5vhhl7@master> Reply-To: Wei Yang References: <20200326222445.18781-1-richard.weiyang@gmail.com> <20200326223604.GP20941@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326223604.GP20941@ziepe.ca> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 26, 2020 at 07:36:04PM -0300, Jason Gunthorpe wrote: >On Thu, Mar 26, 2020 at 10:24:44PM +0000, Wei Yang wrote: >> Since we always clear used_mask before getting node order, we can >> leverage compiler to do this instead of at run time. >> >> Signed-off-by: Wei Yang >> mm/page_alloc.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 0e823bca3f2f..2144b6ceb119 100644 >> +++ b/mm/page_alloc.c >> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat) >> { >> static int node_order[MAX_NUMNODES]; >> int node, load, nr_nodes = 0; >> - nodemask_t used_mask; >> + nodemask_t used_mask = {.bits = {0}}; > >If this style is to be done it should just be '= {}'; > >This case demonstrates why the popular '= {0}' idiom is not such a >good idea, as it only works if the first member is an integral type. > Thanks for your comment. I think David found a better solution. >Jason -- Wei Yang Help you, Help me