From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754DCC2D0E8 for ; Tue, 31 Mar 2020 08:59:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DA2720787 for ; Tue, 31 Mar 2020 08:59:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=d-silva.org header.i=@d-silva.org header.b="H7bb13Em" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DA2720787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=d-silva.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B60256B0037; Tue, 31 Mar 2020 04:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEA6F6B006C; Tue, 31 Mar 2020 04:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8B66B006E; Tue, 31 Mar 2020 04:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id 874966B0037 for ; Tue, 31 Mar 2020 04:59:27 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3D79F8248D51 for ; Tue, 31 Mar 2020 08:59:27 +0000 (UTC) X-FDA: 76655058774.20.grape49_18381c5aefb58 X-HE-Tag: grape49_18381c5aefb58 X-Filterd-Recvd-Size: 12590 Received: from ushosting.nmnhosting.com (ushosting.nmnhosting.com [66.55.73.32]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 08:59:26 +0000 (UTC) Received: from mail2.nmnhosting.com (unknown [202.169.106.97]) by ushosting.nmnhosting.com (Postfix) with ESMTPS id BFE3E2DC6864; Mon, 30 Mar 2020 16:52:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-silva.org; s=201810a; t=1585547580; bh=c5YZBYO+yginh2wx+CLNIvIUORNFUjOABhnB4YY2rcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H7bb13EmE2VTz/xNCZFvHIKXPP3TeNvxDkuS5IRaBtVx57jSBYN2U2LYEtdHLKsJ3 w4c2EU9+WAnUbQQnn2xp5vsvkGT1oVzYp2Z/e9qG1S8bNA5QKVc7iJZO9lmsj3Qm4k YIxHdAmnT7hBPI3FtB6+r7Ep+eYY2O7BpcwMIEw17UqxBr0Ip3WA1RahjZq5SGA5Ao I23uOXicZiWYalDfMaAP2NyfLEbCxHY0EdojnqMAP/6/Tf+OvBKt2S3ukyx4Pr7N3r 6phOUFhEe0kGDr8SDz4olli9RICvKa9rm5WkiTQCTRUSDQb79fCJRSVqKQf6L7vh2K CmuLTORzjDMeh9R9eyh8U6bRW8ofSvDfs5LP7/FcGukxTIsv83kPhH7UTN/r2SoUx4 0TAiI6GwCc26okqemO+Q+PxHryoajtYkGAdoiaHm03kfiZinubmAkuDC9YGhE8celo fgVtJABORQ9OQtMPr394ZBKILzYYqr1Lx6qdvZrvB2OLIfP7Qu/LC0d1Ggjro7FRFo nfEOFx2RlxtY/oMHljhuxCRnhvchR1YYea6iUPgWi01teicDbR1nfWmsbl5z+TTcD4 uyXvwNNJ98kh/UfzbI6Nzah+vwR8aHhe7kl+nvFRZHKmQQknMxkZ+Q/HK/UX9vOF4N yWRGXpaYIXGr/tLjjgQJvnFQ= Received: from localhost.lan ([10.0.1.179]) by mail2.nmnhosting.com (8.15.2/8.15.2) with ESMTP id 02R7C4Ar045934; Fri, 27 Mar 2020 18:12:19 +1100 (AEDT) (envelope-from alastair@d-silva.org) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Subject: [PATCH v4 18/25] nvdimm/ocxl: Add an IOCTL to report controller statistics Date: Fri, 27 Mar 2020 18:11:55 +1100 Message-Id: <20200327071202.2159885-19-alastair@d-silva.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200327071202.2159885-1-alastair@d-silva.org> References: <20200327071202.2159885-1-alastair@d-silva.org> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mail2.nmnhosting.com [10.0.1.20]); Fri, 27 Mar 2020 18:12:19 +1100 (AEDT) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The controller can report a number of statistics that are useful in evaluating the performance and reliability of the card. This patch exposes this information via an IOCTL. Signed-off-by: Alastair D'Silva --- drivers/nvdimm/ocxl/main.c | 220 +++++++++++++++++++++++++++++++++ include/uapi/nvdimm/ocxlpmem.h | 21 ++++ 2 files changed, 241 insertions(+) diff --git a/drivers/nvdimm/ocxl/main.c b/drivers/nvdimm/ocxl/main.c index d0db358ded43..0040fc09cceb 100644 --- a/drivers/nvdimm/ocxl/main.c +++ b/drivers/nvdimm/ocxl/main.c @@ -713,6 +713,221 @@ static int ioctl_controller_dump_complete(struct oc= xlpmem *ocxlpmem) GLOBAL_MMIO_HCI_CONTROLLER_DUMP_COLLECTED); } =20 +/** + * controller_stats_header_parse() - Parse the first 64 bits of the cont= roller stats admin command response + * @ocxlpmem: the device metadata + * @length: out, returns the number of bytes in the response (excluding = the 64 bit header) + */ +static int controller_stats_header_parse(struct ocxlpmem *ocxlpmem, + u32 *length) +{ + int rc; + u64 val; + + u16 data_identifier; + u32 data_length; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + return rc; + + data_identifier =3D val >> 48; + data_length =3D val & 0xFFFFFFFF; + + if (data_identifier !=3D 0x4353) { // 'CS' + dev_err(&ocxlpmem->dev, + "Bad data identifier for error log data, expected 'CS', got '%2s' (%#= x), data_length=3D%u\n", + (char *)&data_identifier, + (unsigned int)data_identifier, data_length); + return -EINVAL; + } + + *length =3D data_length; + return 0; +} + +static int ioctl_controller_stats(struct ocxlpmem *ocxlpmem, + struct ioctl_ocxlpmem_controller_stats __user *uarg) +{ + struct ioctl_ocxlpmem_controller_stats args; + u32 length; + int rc; + u64 val; + + memset(&args, '\0', sizeof(args)); + + mutex_lock(&ocxlpmem->admin_command.lock); + + rc =3D ocxl_global_mmio_write64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.request_offset + 0x08, + OCXL_LITTLE_ENDIAN, 0); + if (rc) + goto out; + + rc =3D admin_command_execute(ocxlpmem, ADMIN_COMMAND_CONTROLLER_STATS); + if (rc < 0) + goto out; + if (rc !=3D STATUS_SUCCESS) { + warn_status(ocxlpmem, + "Unexpected status from controller stats", rc); + goto out; + } + + rc =3D controller_stats_header_parse(ocxlpmem, &length); + if (rc) + goto out; + + if (length !=3D 0x140) // Documented length of controller stats respons= e + warn_status(ocxlpmem, + "Unexpected length for controller stats data, expected 0x140, got= 0x%x", + length); + +#define SPID1_OFFSET (ocxlpmem->admin_command.data_offset + 0x08) +#define SPID2_OFFSET (ocxlpmem->admin_command.data_offset + 0x48) +#define RESET_INFO (SPID1_OFFSET + 0x08) +#define UPTIME_LIFE (SPID1_OFFSET + 0x10) +#define CRITICAL_UTIL (SPID2_OFFSET + 0x08) +#define HOST_LOAD_COUNT (SPID2_OFFSET + 0x10) +#define HOST_STORE_COUNT (SPID2_OFFSET + 0x18) +#define HOST_LOAD_DURATION (SPID2_OFFSET + 0x20) +#define HOST_STORE_DURATION (SPID2_OFFSET + 0x28) +#define MEDIA_READ_COUNT (SPID2_OFFSET + 0x50) +#define MEDIA_WRITE_COUNT (SPID2_OFFSET + 0x58) +#define MEDIA_READ_DURATION (SPID2_OFFSET + 0x60) +#define MEDIA_WRITE_DURATION (SPID2_OFFSET + 0x68) +#define CACHE_READ_HIT_COUNT (SPID2_OFFSET + 0x90) +#define CACHE_WRITE_HIT_COUNT (SPID2_OFFSET + 0x98) +#define FAST_WRITE_COUNT (SPID2_OFFSET + 0xA0) + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, SPID1_OFFSET, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + if ((val >> 56) !=3D 0x01) { // Check the parameter ID + rc =3D -ENODEV; + goto out; + } + if ((val & 0xFFFFFFFF) !=3D 0x38) { // Check the length + rc =3D -ENODEV; + goto out; + } + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, RESET_INFO, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + + args.reset_count =3D val >> 32; + args.reset_uptime =3D val & 0xFFFFFFFF; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, UPTIME_LIFE, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + + args.power_on_uptime =3D val >> 32; + args.life_remaining =3D val & 0xFF; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, SPID2_OFFSET, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + if ((val >> 56) !=3D 0x02) { // Check the parameter ID + rc =3D -ENODEV; + goto out; + } + if ((val & 0xFFFFFFFF) !=3D 0xF8) { // Check the length + rc =3D -ENODEV; + goto out; + } + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, CRITICAL_UTIL, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + + args.critical_resource_utilization =3D val & 0xff; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, HOST_LOAD_COUNT, + OCXL_LITTLE_ENDIAN, + &args.host_load_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, HOST_STORE_COUNT, + OCXL_LITTLE_ENDIAN, + &args.host_store_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, HOST_LOAD_DURATION, + OCXL_LITTLE_ENDIAN, + &args.host_load_duration); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, HOST_STORE_DURATION, + OCXL_LITTLE_ENDIAN, + &args.host_store_duration); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, MEDIA_READ_COUNT, + OCXL_LITTLE_ENDIAN, + &args.media_read_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, MEDIA_WRITE_COUNT, + OCXL_LITTLE_ENDIAN, + &args.media_write_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, MEDIA_READ_DURATION, + OCXL_LITTLE_ENDIAN, + &args.media_read_duration); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, MEDIA_WRITE_DURATION= , + OCXL_LITTLE_ENDIAN, + &args.media_write_duration); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, CACHE_READ_HIT_COUNT= , + OCXL_LITTLE_ENDIAN, + &args.cache_read_hit_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, CACHE_WRITE_HIT_COUN= T, + OCXL_LITTLE_ENDIAN, + &args.cache_write_hit_count); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, FAST_WRITE_COUNT, + OCXL_LITTLE_ENDIAN, + &args.fast_write_count); + if (rc) + goto out; + + if (copy_to_user(uarg, &args, sizeof(args))) { + rc =3D -EFAULT; + goto out; + } + + rc =3D admin_response_handled(ocxlpmem); + +out: + mutex_unlock(&ocxlpmem->admin_command.lock); + return rc; +} + static long file_ioctl(struct file *file, unsigned int cmd, unsigned lon= g args) { struct ocxlpmem *ocxlpmem =3D file->private_data; @@ -736,6 +951,11 @@ static long file_ioctl(struct file *file, unsigned i= nt cmd, unsigned long args) case IOCTL_OCXLPMEM_CONTROLLER_DUMP_COMPLETE: rc =3D ioctl_controller_dump_complete(ocxlpmem); break; + + case IOCTL_OCXLPMEM_CONTROLLER_STATS: + rc =3D ioctl_controller_stats(ocxlpmem, + (struct ioctl_ocxlpmem_controller_stats __user *)args); + break; } =20 return rc; diff --git a/include/uapi/nvdimm/ocxlpmem.h b/include/uapi/nvdimm/ocxlpme= m.h index 05e2b3f7b27c..ca3a7098fa9d 100644 --- a/include/uapi/nvdimm/ocxlpmem.h +++ b/include/uapi/nvdimm/ocxlpmem.h @@ -51,6 +51,26 @@ struct ioctl_ocxlpmem_controller_dump_data { __u64 reserved[8]; }; =20 +struct ioctl_ocxlpmem_controller_stats { + __u32 reset_count; + __u32 reset_uptime; /* seconds */ + __u32 power_on_uptime; /* seconds */ + __u8 life_remaining; /* percentage, 0-100 */ + __u8 critical_resource_utilization; /* percentage, 0-100 */ + __u8 reserved[2]; + __u64 host_load_count; + __u64 host_store_count; + __u64 host_load_duration; /* nanoseconds, total */ + __u64 host_store_duration; /* nanoseconds, total */ + __u64 media_read_count; + __u64 media_write_count; + __u64 media_read_duration; /* nanoseconds, total */ + __u64 media_write_duration; /* nanoseconds, total */ + __u64 cache_read_hit_count; + __u64 cache_write_hit_count; + __u64 fast_write_count; +}; + /* ioctl numbers */ #define OCXLPMEM_MAGIC 0xCA /* OpenCAPI Persistent memory devices */ @@ -58,5 +78,6 @@ struct ioctl_ocxlpmem_controller_dump_data { #define IOCTL_OCXLPMEM_CONTROLLER_DUMP _IO(OCXLPMEM_MAGIC, 0x31) #define IOCTL_OCXLPMEM_CONTROLLER_DUMP_DATA _IOWR(OCXLPMEM_MAGIC, 0x32,= struct ioctl_ocxlpmem_controller_dump_data) #define IOCTL_OCXLPMEM_CONTROLLER_DUMP_COMPLETE _IO(OCXLPMEM_MAGIC, 0x3= 3) +#define IOCTL_OCXLPMEM_CONTROLLER_STATS _IO(OCXLPMEM_MAGIC, 0x34) =20 #endif /* _UAPI_OCXL_SCM_H */ --=20 2.24.1