From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45359C43331 for ; Wed, 25 Mar 2020 14:29:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 128A720714 for ; Wed, 25 Mar 2020 14:29:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 128A720714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C6936B000A; Wed, 25 Mar 2020 10:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 950F96B000C; Wed, 25 Mar 2020 10:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817DE6B000D; Wed, 25 Mar 2020 10:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 667B16B000A for ; Wed, 25 Mar 2020 10:29:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2BD88181AD0A5 for ; Wed, 25 Mar 2020 14:29:40 +0000 (UTC) X-FDA: 76634118120.11.ring53_5464008aaf12a X-HE-Tag: ring53_5464008aaf12a X-Filterd-Recvd-Size: 3401 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 14:29:39 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id b2so3319734wrj.10 for ; Wed, 25 Mar 2020 07:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xK7fLCOSSVH8HJsoEd66t540+DpWVzc878w2lJBoIek=; b=NJYgtDlmWCXa1eFewjSlrOf0XGMXfYsKJy09CA7Kih8qldK34pQoAQACQsKBpijEJS eaq/0dWtTWxs7GW8/NFdWDu27uFY9m+5JpCqKcoj4oVncuOBixEmmU7bswC1X29uenXd YA/1rVV5ok2JeAMXm+ho/0brGd5GUTvluRi9X8dx8stxnbvQ6rWh1yEmixLkwqq5vLMd whbOJ7QSoezCZrd6Pq3Lc8T84wt+CGG/lGUVGCgcU/PLcHhHPfvaLEHmaMAlL6h4Xonz I0HikKEeiNjgzTvhrCfQStw06UaQBFZDO6EZ3+ra1HYzojbLhVohBIGQB48SopiZpOsB 9o1Q== X-Gm-Message-State: ANhLgQ0/z6pPeEnvXeimZ/EDmhGCCQ5XE+LpSpfI4QcdSm34ao71rT4/ JsFlrQZJf3RqijEp8SAdnJU= X-Google-Smtp-Source: ADFU+vvV+iXXv1GpZUfxs9nW5CvCN4kTMNBy1SnvAwfCo+uprHM46YrQo6ZhbZ/Dwea7ETji/N05WQ== X-Received: by 2002:a5d:4683:: with SMTP id u3mr3723218wrq.248.1585146578476; Wed, 25 Mar 2020 07:29:38 -0700 (PDT) Received: from localhost (ip-37-188-135-150.eurotel.cz. [37.188.135.150]) by smtp.gmail.com with ESMTPSA id b15sm33619364wru.70.2020.03.25.07.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 07:29:37 -0700 (PDT) Date: Wed, 25 Mar 2020 15:29:36 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" Subject: Re: [RFC v2 2/2] kernel/sysctl: support handling command line aliases Message-ID: <20200325142936.GC19542@dhcp22.suse.cz> References: <20200325120345.12946-1-vbabka@suse.cz> <20200325120345.12946-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325120345.12946-2-vbabka@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Both patches look really great to me. I haven't really checked all the details but from a quick glance they both seem ok. I would just add a small clarification here. Unless I am mistaken early_param is called earlier than it would be now. But that shouldn't cause any problems because the underlying implementation is just a noop for backward compatibility. Thanks a lot this looks like a very nice improvement. On Wed 25-03-20 13:03:45, Vlastimil Babka wrote: [...] > -static __init int setup_numa_zonelist_order(char *s) > -{ > - if (!s) > - return 0; > - > - return __parse_numa_zonelist_order(s); > -} > -early_param("numa_zonelist_order", setup_numa_zonelist_order); > - > char numa_zonelist_order[] = "Node"; > > /* > -- > 2.25.1 -- Michal Hocko SUSE Labs