From: Jason Gunthorpe <jgg@mellanox.com>
To: Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH v3] mm/mmu_notifier: prevent unpaired invalidate_start and invalidate_end
Date: Wed, 25 Mar 2020 09:14:07 -0300 [thread overview]
Message-ID: <20200325121407.GU13183@mellanox.com> (raw)
In-Reply-To: <20200325080117.GY19542@dhcp22.suse.cz>
On Wed, Mar 25, 2020 at 09:01:17AM +0100, Michal Hocko wrote:
> > > I'm going to put this in linux-next to see if there are any reports of
> > > the pr_warn failing.
> > >
> > > Michal, are you happy with this solution now?
> >
> > It's been a month in linux-next now, with no complaints. If there are
> > no comments I will go ahead to send it in the hmm PR.
>
> I will not block this but it still looks like a wrong approach. A more
> robust solution would be to allow calling invalidate_range_end even for
> the failing invalidate_start.
That requires reliably walking a rcu list backwards under rcu. I don't
have a good feeling about that algorithm. Do you know of a solution?
Since we don't actually have any users that care about this any more,
I felt this testable solution was better.
Jason
next prev parent reply other threads:[~2020-03-25 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 20:52 Jason Gunthorpe
2020-02-11 21:28 ` Ralph Campbell
2020-02-11 23:42 ` Jason Gunthorpe
2020-02-28 13:50 ` Jason Gunthorpe
2020-03-24 19:41 ` Jason Gunthorpe
2020-03-25 8:01 ` Michal Hocko
2020-03-25 12:14 ` Jason Gunthorpe [this message]
2020-03-25 13:06 ` Michal Hocko
2020-03-26 13:06 ` Qian Cai
2020-03-26 14:56 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325121407.GU13183@mellanox.com \
--to=jgg@mellanox.com \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox