From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D4BC41621 for ; Tue, 24 Mar 2020 18:44:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D4042137B for ; Tue, 24 Mar 2020 18:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D4042137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D67216B000A; Tue, 24 Mar 2020 14:44:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D16AE6B000C; Tue, 24 Mar 2020 14:44:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C8F6B000D; Tue, 24 Mar 2020 14:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id A6C876B000A for ; Tue, 24 Mar 2020 14:44:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3CB2D18607F6D for ; Tue, 24 Mar 2020 18:44:41 +0000 (UTC) X-FDA: 76631131962.01.stick87_45f9f8cd13a0c X-HE-Tag: stick87_45f9f8cd13a0c X-Filterd-Recvd-Size: 3347 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 18:44:40 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B969B2074D; Tue, 24 Mar 2020 18:44:37 +0000 (UTC) Date: Tue, 24 Mar 2020 14:44:36 -0400 From: Steven Rostedt To: Zhenyu Ye Cc: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v4 4/6] mm: Add page table level flags to vm_flags Message-ID: <20200324144436.043659c2@gandalf.local.home> In-Reply-To: <20200324134534.1570-5-yezhenyu2@huawei.com> References: <20200324134534.1570-1-yezhenyu2@huawei.com> <20200324134534.1570-5-yezhenyu2@huawei.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 24 Mar 2020 21:45:32 +0800 Zhenyu Ye wrote: > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -130,6 +130,16 @@ IF_HAVE_PG_IDLE(PG_idle, "idle" ) > #define IF_HAVE_VM_SOFTDIRTY(flag,name) > #endif > > +#ifdef CONFIG_64BIT > +#define IF_HAVE_VM_LEVEL_PUD(flag,name) {flag, name} > +#define IF_HAVE_VM_LEVEL_PMD(flag,name) {flag, name} > +#define IF_HAVE_VM_LEVEL_PTE(flag,name) {flag, name} > +#else > +#define IF_HAVE_VM_LEVEL_PUD(flag,name) > +#define IF_HAVE_VM_LEVEL_PMD(flag,name) > +#define IF_HAVE_VM_LEVEL_PTE(flag,name) > +#endif > + > #define __def_vmaflag_names \ > {VM_READ, "read" }, \ > {VM_WRITE, "write" }, \ > @@ -161,7 +171,10 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty" ) \ > {VM_MIXEDMAP, "mixedmap" }, \ > {VM_HUGEPAGE, "hugepage" }, \ > {VM_NOHUGEPAGE, "nohugepage" }, \ > - {VM_MERGEABLE, "mergeable" } \ > + {VM_MERGEABLE, "mergeable" }, \ > +IF_HAVE_VM_LEVEL_PUD(VM_LEVEL_PUD, "pud-level" ), \ > +IF_HAVE_VM_LEVEL_PMD(VM_LEVEL_PMD, "pmd-level" ), \ > +IF_HAVE_VM_LEVEL_PTE(VM_LEVEL_PTE, "pte-level" ) \ > Have you tested this on 32bit? It looks like you'll get empty commas there. Perhaps the defines need to be: #ifdef CONFIG_64BIT #define IF_HAVE_VM_LEVEL_PUD(flag,name) {flag, name}, #define IF_HAVE_VM_LEVEL_PMD(flag,name) {flag, name}, #define IF_HAVE_VM_LEVEL_PTE(flag,name) {flag, name} #else #define IF_HAVE_VM_LEVEL_PUD(flag,name) #define IF_HAVE_VM_LEVEL_PMD(flag,name) #define IF_HAVE_VM_LEVEL_PTE(flag,name) #endif And leave out the commas in the list. -- Steve