From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED68FC4332B for ; Tue, 24 Mar 2020 07:37:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5DDC20719 for ; Tue, 24 Mar 2020 07:37:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5DDC20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 71EA46B00DC; Tue, 24 Mar 2020 03:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD4C6B00DD; Tue, 24 Mar 2020 03:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609A66B00DE; Tue, 24 Mar 2020 03:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 49A596B00DC for ; Tue, 24 Mar 2020 03:37:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A014C180C3A53 for ; Tue, 24 Mar 2020 07:37:49 +0000 (UTC) X-FDA: 76629451458.17.care70_444aedbaefe44 X-HE-Tag: care70_444aedbaefe44 X-Filterd-Recvd-Size: 1878 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 07:37:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6123068BFE; Tue, 24 Mar 2020 08:37:46 +0100 (CET) Date: Tue, 24 Mar 2020 08:37:46 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: Re: [PATCH v2 hmm 7/9] mm/hmm: do not unconditionally set pfns when returning EBUSY Message-ID: <20200324073746.GF23447@lst.de> References: <20200324011457.2817-1-jgg@ziepe.ca> <20200324011457.2817-8-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324011457.2817-8-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 23, 2020 at 10:14:55PM -0300, Jason Gunthorpe wrote: > if (pte_none(pte)) { > required_fault = hmm_pte_need_fault(hmm_vma_walk, orig_pfn, 0); > if (required_fault) > goto fault; > + *pfn = range->values[HMM_PFN_NONE]; > return 0; > } > > @@ -274,8 +274,10 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, > } > > required_fault = hmm_pte_need_fault(hmm_vma_walk, orig_pfn, 0); > - if (!required_fault) > + if (!required_fault) { > + *pfn = range->values[HMM_PFN_NONE]; > return 0; > + } Maybe throw in a goto hole to consolidaste the set PFN and return 0 cases? Otherwise looks good: Reviewed-by: Christoph Hellwig