From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405B9C54FD9 for ; Mon, 23 Mar 2020 20:24:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E60782073E for ; Mon, 23 Mar 2020 20:24:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KW3zwJHc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E60782073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BFCC38E0007; Mon, 23 Mar 2020 16:23:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB27A8E0006; Mon, 23 Mar 2020 16:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852C28E0008; Mon, 23 Mar 2020 16:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 5D5D08E0007 for ; Mon, 23 Mar 2020 16:23:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0C1A5117EC for ; Mon, 23 Mar 2020 20:23:16 +0000 (UTC) X-FDA: 76627751592.01.beef24_90e9b5609794c X-HE-Tag: beef24_90e9b5609794c X-Filterd-Recvd-Size: 5537 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Mar 2020 20:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=pyRJmQL4PX3Z7ghW+iu22GLUiZYywjsnI5INAzyHKKM=; b=KW3zwJHcUgGtVxfKSB5Y+6+/sc tK7ee+lQPoOk5IA/tqiZMcvb7gMtLNBLuTFzQvO4kbKh2ObzC9GAwlSz1RsCLyheeDedCbRTqnJHz fv0I8HbPhMbMmNzAL5ikwiWibrQKZDC6ZszJjawzqwhQqkcdcGVH7Ci71xSkPKk+mVlVvE7CvuvB7 gb6lWgkBrgsrMrAHKhkZlllmkbijZMDX2BxvNM4O4dLq2jcs9S7Cgobn8v2WKnOcVoY+ejcxwSuaD fFWnC90a/g5NuLP5yqZMf26TATijZWhxjx8liW9PNliJ8BTLC2q8CN2Uv84ylu9H1JbCxhreRndle ScSK4IRQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGTbC-0003W6-6P; Mon, 23 Mar 2020 20:23:02 +0000 From: Matthew Wilcox To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Dave Chinner , William Kucharski Subject: [PATCH v10 24/25] fuse: Convert from readpages to readahead Date: Mon, 23 Mar 2020 13:22:58 -0700 Message-Id: <20200323202259.13363-25-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200323202259.13363-1-willy@infradead.org> References: <20200323202259.13363-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Use the new readahead operation in fuse. Switching away from the read_cache_pages() helper gets rid of an implicit call to put_page(), so we can get rid of the get_page() call in fuse_readpages_fill(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Dave Chinner Reviewed-by: William Kucharski --- fs/fuse/file.c | 46 +++++++++++++++++++--------------------------- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 9d67b830fb7a..5749505bcff6 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -923,9 +923,8 @@ struct fuse_fill_data { unsigned int max_pages; }; =20 -static int fuse_readpages_fill(void *_data, struct page *page) +static int fuse_readpages_fill(struct fuse_fill_data *data, struct page = *page) { - struct fuse_fill_data *data =3D _data; struct fuse_io_args *ia =3D data->ia; struct fuse_args_pages *ap =3D &ia->ap; struct inode *inode =3D data->inode; @@ -941,10 +940,8 @@ static int fuse_readpages_fill(void *_data, struct p= age *page) fc->max_pages); fuse_send_readpages(ia, data->file); data->ia =3D ia =3D fuse_io_alloc(NULL, data->max_pages); - if (!ia) { - unlock_page(page); + if (!ia) return -ENOMEM; - } ap =3D &ia->ap; } =20 @@ -954,7 +951,6 @@ static int fuse_readpages_fill(void *_data, struct pa= ge *page) return -EIO; } =20 - get_page(page); ap->pages[ap->num_pages] =3D page; ap->descs[ap->num_pages].length =3D PAGE_SIZE; ap->num_pages++; @@ -962,37 +958,33 @@ static int fuse_readpages_fill(void *_data, struct = page *page) return 0; } =20 -static int fuse_readpages(struct file *file, struct address_space *mappi= ng, - struct list_head *pages, unsigned nr_pages) +static void fuse_readahead(struct readahead_control *rac) { - struct inode *inode =3D mapping->host; + struct inode *inode =3D rac->mapping->host; struct fuse_conn *fc =3D get_fuse_conn(inode); struct fuse_fill_data data; - int err; + struct page *page; =20 - err =3D -EIO; if (is_bad_inode(inode)) - goto out; + return; =20 - data.file =3D file; + data.file =3D rac->file; data.inode =3D inode; - data.nr_pages =3D nr_pages; - data.max_pages =3D min_t(unsigned int, nr_pages, fc->max_pages); -; + data.nr_pages =3D readahead_count(rac); + data.max_pages =3D min_t(unsigned int, data.nr_pages, fc->max_pages); data.ia =3D fuse_io_alloc(NULL, data.max_pages); - err =3D -ENOMEM; if (!data.ia) - goto out; + return; =20 - err =3D read_cache_pages(mapping, pages, fuse_readpages_fill, &data); - if (!err) { - if (data.ia->ap.num_pages) - fuse_send_readpages(data.ia, file); - else - fuse_io_free(data.ia); + while ((page =3D readahead_page(rac))) { + if (fuse_readpages_fill(&data, page) !=3D 0) + return; } -out: - return err; + + if (data.ia->ap.num_pages) + fuse_send_readpages(data.ia, rac->file); + else + fuse_io_free(data.ia); } =20 static ssize_t fuse_cache_read_iter(struct kiocb *iocb, struct iov_iter = *to) @@ -3373,10 +3365,10 @@ static const struct file_operations fuse_file_ope= rations =3D { =20 static const struct address_space_operations fuse_file_aops =3D { .readpage =3D fuse_readpage, + .readahead =3D fuse_readahead, .writepage =3D fuse_writepage, .writepages =3D fuse_writepages, .launder_page =3D fuse_launder_page, - .readpages =3D fuse_readpages, .set_page_dirty =3D __set_page_dirty_nobuffers, .bmap =3D fuse_bmap, .direct_IO =3D fuse_direct_IO, --=20 2.25.1