From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF31C54EEB for ; Mon, 23 Mar 2020 17:44:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56B9E20658 for ; Mon, 23 Mar 2020 17:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="t8NTd9RM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56B9E20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 016A56B0007; Mon, 23 Mar 2020 13:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F30466B0008; Mon, 23 Mar 2020 13:44:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E47106B000A; Mon, 23 Mar 2020 13:44:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id CE1046B0007 for ; Mon, 23 Mar 2020 13:44:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6E180585F for ; Mon, 23 Mar 2020 17:44:31 +0000 (UTC) X-FDA: 76627351542.21.cars95_447c4a0cad529 X-HE-Tag: cars95_447c4a0cad529 X-Filterd-Recvd-Size: 7380 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Mar 2020 17:44:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLDo65F41jzRRosNB9M+tAwu945PZJN3n8StiI4R78I10wqXc94RYoDZBQ/aZc36/9al5TRoWhoJmzCdhxQjodTPwkCBrEY2gcZHJb8u2B5QnBGlu5ueiARcdV5gLpwzhC0jJWof6dwNqzP1kAELs6cDno+42+orvmMGlp2Ao5pSf3nxrJveVNUBEloqSOayG98xPl9o9/jaPcSPmq5RGHEEKkV0H85V1jgamGagBnOpIgbPF02WzjsSn5oC9R/8FJcriaatpkdnF8oMuDdHu7ZpNsq5ZXaYKEQg7g75znyCHlRqHtdp49W7+D7NRpJtbtgKUiTh8vIe8OPeLwr8Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAL8vzgYjFTghvLv+4uYrXBxDxq28m64SizePBNQAW8=; b=e2MtvVgJy8MCyEle3CoqACO9NdvzKE1jbLbZhPwf6NRCtP3+Gm0LWbrVIQVrvXsPqLXh3wiaB7X593jGVFZptUhYKZi/6bejew51/GipHcrmqnSQ4D5eclw5FEVW5wxxNgYvLtSWlAzVY8UMrxHrvSIss+HqDz/eC4k5+u3bwrrp8SDYomRQTGVp2/DC2Pg20xXucuBg2lYLnJnrjuEp8IteCr6L2mWQsDl2Dce8IFQ5BbZ55RIyhjr7nWyG4kPTnfbWyb5tNM7ds25jmePWMLzq0YhLmdm8wxH5f6vnTBXsMdJ8wIpHdRaGF+A2WBt2UQ5mxGY+0hFe76mRnvo55Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAL8vzgYjFTghvLv+4uYrXBxDxq28m64SizePBNQAW8=; b=t8NTd9RM/dyANqXCgEUTHFcXyCkM1h1LWjHrEXqgwdpRZ3BOMLBPPjTjHyyPddGlu3ZejY8eVX8NpKiKzYt+QTtmEGASRtm4+Zt/otE7iQtf3Qw4Lsl1SeOOspEHOhyVFAaovfEc9TVsqq7PMHLKPPuMC2w+JKncKRMfX/GUTjQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (52.133.14.15) by VI1PR05MB4895.eurprd05.prod.outlook.com (20.177.51.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Mon, 23 Mar 2020 17:44:27 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::18d2:a9ea:519:add3]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::18d2:a9ea:519:add3%7]) with mapi id 15.20.2835.021; Mon, 23 Mar 2020 17:44:27 +0000 Date: Mon, 23 Mar 2020 14:44:23 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Philip Yang Subject: Re: [PATCH hmm 6/6] mm/hmm: use device_private_entry_to_pfn() Message-ID: <20200323174423.GC13183@mellanox.com> References: <20200320164905.21722-1-jgg@ziepe.ca> <20200320164905.21722-7-jgg@ziepe.ca> <20200321084347.GF28695@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200321084347.GF28695@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MN2PR06CA0008.namprd06.prod.outlook.com (2603:10b6:208:23d::13) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:44::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (142.68.57.212) by MN2PR06CA0008.namprd06.prod.outlook.com (2603:10b6:208:23d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18 via Frontend Transport; Mon, 23 Mar 2020 17:44:27 +0000 Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jGR7f-0007CQ-Na; Mon, 23 Mar 2020 14:44:23 -0300 X-Originating-IP: [142.68.57.212] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 40317a86-7202-4755-60a2-08d7cf51d516 X-MS-TrafficTypeDiagnostic: VI1PR05MB4895: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0351D213B3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(199004)(52116002)(5660300002)(8936002)(2906002)(33656002)(81166006)(81156014)(8676002)(6916009)(4326008)(54906003)(316002)(86362001)(66946007)(66556008)(66476007)(478600001)(2616005)(26005)(186003)(36756003)(9786002)(9746002)(1076003)(24400500001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB4895;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sh5jcsRyK+ZyYKucTE1C2t8/esc+jJ1kCXwO2yrGhFTXYiRKmqA6xJOfX13faPISDJEFfDfUFLwr9XkufTLvnaTH2PpPcrkKGSkS2HGz4lykvpyq8TAIvZZR+wcbhm7FwNDoy0cMIEl2aHk18b9eswmwswl8E1tidGZNZy5EGxM3eLJi1FPoR5NWpVgztIpPF+RDRm/mHNW62OCC7RCCG8uapb0cIn7Ix4KVaRToX3GkH/krOrAaVqWUmpOk5Cq8ebEGIyOy1rua+mrbz8R/7fSh++wedl0sODwCkBP2vEtijRJiHo94ZP3CFIhQGgHKIcPHDhJm6WEvyzeGRpbHtL3DPwGf4zMG9xcbzPVp8pYf7Eb9IpEnSa6KzkDllILEJeCCj6mU3s/lqNfEtGLYmG6/Alai2S2WwXaHJIm/sREFFgk7l5Ox6PMi2fLqKHZlrH84YOFMtIBOnCGXGyTJ/Hsg1FdM8/b31zp5xtMLElNGfqEuY93RYKXip8Oa2ltx X-MS-Exchange-AntiSpam-MessageData: j5BfDv0oYef3dHodcP9nBaRpJKCpAwkXsX1YEH5YWYWMQG354js7NAecAuvU50oAfIATTaRUfJDTR0OUSLrnmjjlU33mF0YEgntGo69fWm96ihGtNQbXVT2Txncki/5t9001Bwm5/lFRSUznwz8y8g== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40317a86-7202-4755-60a2-08d7cf51d516 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2020 17:44:27.1688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XcR1hhe787yDKWV+X2ZjghNtvCMY6/jyA8v/391/1DzNh7lvqTmBk3zA6G/fKkXu+23m+xUFcp9SYYB81a8SMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4895 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 21, 2020 at 09:43:47AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:05PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > swp_offset() should not be called directly, the wrappers are supposed to > > abstract away the encoding of the device_private specific information in > > the swap entry. > > > > Signed-off-by: Jason Gunthorpe > > mm/hmm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/hmm.c b/mm/hmm.c > > index a09b4908e9c81a..fd9ee2b5fd9989 100644 > > +++ b/mm/hmm.c > > @@ -259,8 +259,8 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, > > * the PFN even if not present. > > */ > > if (hmm_is_device_private_entry(range, entry)) { > > - *pfn = hmm_device_entry_from_pfn(range, > > - swp_offset(entry)); > > + *pfn = hmm_device_entry_from_pfn( > > + range, device_private_entry_to_pfn(entry)); > > The range parameter can stay on the first line.. Done. Makes the diff smaller. Thanks, Jason