From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647BFC54EEB for ; Mon, 23 Mar 2020 07:10:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 295542074D for ; Mon, 23 Mar 2020 07:10:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K1hSlvo7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 295542074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B1D1C6B0005; Mon, 23 Mar 2020 03:10:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACDAF6B0006; Mon, 23 Mar 2020 03:10:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A656B0007; Mon, 23 Mar 2020 03:10:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 856DF6B0005 for ; Mon, 23 Mar 2020 03:10:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4B9064DBC for ; Mon, 23 Mar 2020 07:10:03 +0000 (UTC) X-FDA: 76625752686.14.corn53_3a9feeaff5541 X-HE-Tag: corn53_3a9feeaff5541 X-Filterd-Recvd-Size: 3234 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Mar 2020 07:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584947402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KelROyYCjluM3/vlH+wAUHU21yGj/l+XL1RLQ+Rw5s=; b=K1hSlvo7qtwVN0gQ304LNSblV4MrBX9eFFdXOGQ8Ts4ZUiWiaPvV8251Fbagxty6AkQq+M RFxhK8iGHAOr4aYQIQoroMUUnmtpvNbZEeIzGMIZAu4f/D+pO5E/ebhcuC6onvFik4LT5R +SDsWNi6LdAokLgWWJn2HqUBvAT/J9k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-71Ubue3VNFaQw_p3ZvZ1Mg-1; Mon, 23 Mar 2020 03:09:58 -0400 X-MC-Unique: 71Ubue3VNFaQw_p3ZvZ1Mg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2945A800D5B; Mon, 23 Mar 2020 07:09:56 +0000 (UTC) Received: from localhost (ovpn-13-26.pek2.redhat.com [10.72.13.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FF0D94978; Mon, 23 Mar 2020 07:09:54 +0000 (UTC) Date: Mon, 23 Mar 2020 15:09:52 +0800 From: Baoquan He To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com, Ye Xiaolong , David Rientjes , Joonsoo Kim Subject: Re: [PATCH v4 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx Message-ID: <20200323070952.GF3039@MiWiFi-R3L-srv> References: <1584938972-7430-1-git-send-email-iamjoonsoo.kim@lge.com> <1584938972-7430-3-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584938972-7430-3-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/23/20 at 01:49pm, js1304@gmail.com wrote: > From: Joonsoo Kim > > classzone_idx is just different name for high_zoneidx now. > So, integrate them and add some comment to struct alloc_context > in order to reduce future confusion about the meaning of this variable. > > The accessor, ac_classzone_idx() is also removed since it isn't needed > after integration. > > In addition to integration, this patch also renames high_zoneidx > to highest_zoneidx since it represents more precise meaning. > > Signed-off-by: Joonsoo Kim The patch looks good, and did the basic test after applying this patch series. FWIW: Reviewed-by: Baoquan He