From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B29C4332B for ; Thu, 19 Mar 2020 17:13:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E41C12072D for ; Thu, 19 Mar 2020 17:13:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E41C12072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D22F6B0003; Thu, 19 Mar 2020 13:13:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 882B56B0005; Thu, 19 Mar 2020 13:13:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 798436B0007; Thu, 19 Mar 2020 13:13:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 5EF026B0003 for ; Thu, 19 Mar 2020 13:13:40 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9A3B3184C6E67 for ; Thu, 19 Mar 2020 17:13:39 +0000 (UTC) X-FDA: 76612758558.15.bead28_288051db1949 X-HE-Tag: bead28_288051db1949 X-Filterd-Recvd-Size: 3857 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 17:13:37 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id f130so2234117wmf.4 for ; Thu, 19 Mar 2020 10:13:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mjce+PtajvBrnNU6PU3NbzED18KwcHrcpD9gbDuRtfI=; b=bouLwyJH8zhZOed+pAPi67NB85I6V61FDcI8oixhGA98PK8QDAYrQJlNK+eCk8lIo5 JeDXaFOwACWltSvJ7LZ7yAoQ0Hwu4pm4ntYLz6f92wU9QDs9HdpYpE652vOYuE6JMvwK waYeYKiw5ISu1nU9gz7FrOmFDXPHiWkmQGDcfc8POMeu8f18TjmHtQwaOPiO7Jz5OpaD wjta/iauD/trMUtpDQDYJh0mgrsJthnHAh6SBovPQXJDtnAwzes4/iKz6iENEUuNOl/q XTei3+sx5K+lQi7qPSLNGSuHYY2WVtTv534h2WgYC42YGiFBOXmZmCtMXJsUa0rCjnp3 3w0w== X-Gm-Message-State: ANhLgQ3VxWqrHvGLlvWPWbrQeW3UQNj2aRaA5d0txeqdls1X1NRmu/Cj Ek6x5Z7IrDoOIjfiRY3GJLo= X-Google-Smtp-Source: ADFU+vt9yj55QpEIdAl5B4oDZ7rybmPOo/HI7euCOLhJ6V8N5Ra/j0xMqNNJkJEPaz27A4ujJPEm6w== X-Received: by 2002:a1c:147:: with SMTP id 68mr4966843wmb.28.1584638016173; Thu, 19 Mar 2020 10:13:36 -0700 (PDT) Received: from localhost (ip-37-188-140-107.eurotel.cz. [37.188.140.107]) by smtp.gmail.com with ESMTPSA id g3sm4544841wro.93.2020.03.19.10.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 10:13:35 -0700 (PDT) Date: Thu, 19 Mar 2020 18:13:34 +0100 From: Michal Hocko To: mateusznosek0@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Johannes Weiner Subject: Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment Message-ID: <20200319171334.GK20800@dhcp22.suse.cz> References: <20200319165938.23354-1-mateusznosek0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319165938.23354-1-mateusznosek0@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is usually preferable to Cc author of the code (added Johannes) On Thu 19-03-20 17:59:38, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously 0 was assigned to 'sc->skipped_deactivate'. It could happen only > if 'sc->skipped_deactivate' was 0 so the assignment is unnecessary and can > be removed. The above wording was a bit hard to understdand for me. I would go with " sc->memcg_low_skipped resets skipped_deactivate to 0 but this is not needed as this code path is never reachable with skipped_deactivate != 0 due to previous sc->skipped_deactivate branch. " > Signed-off-by: Mateusz Nosek The patch is correct. I am not sure it results in a better code though. I will defer to Johannes here. I suspect he simply wanted to express that skipped_deactivate should be always reset when retrying the direct reclaim. After this patch this could be lost in future changes so the code would be more subtle. But I am only guessing here. > --- > mm/vmscan.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index dca623db51c8..453ff2abcb58 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3093,7 +3093,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, > if (sc->memcg_low_skipped) { > sc->priority = initial_priority; > sc->force_deactivate = 0; > - sc->skipped_deactivate = 0; > sc->memcg_low_reclaim = 1; > sc->memcg_low_skipped = 0; > goto retry; > -- > 2.17.1 -- Michal Hocko SUSE Labs