From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BA8C4332D for ; Thu, 19 Mar 2020 17:02:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 415732080C for ; Thu, 19 Mar 2020 17:02:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 415732080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 076526B0007; Thu, 19 Mar 2020 13:02:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026C96B0008; Thu, 19 Mar 2020 13:02:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7E576B0010; Thu, 19 Mar 2020 13:02:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id CC1796B0007 for ; Thu, 19 Mar 2020 13:02:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 641D518464189 for ; Thu, 19 Mar 2020 17:02:13 +0000 (UTC) X-FDA: 76612729746.17.toe65_2f00a4547921e X-HE-Tag: toe65_2f00a4547921e X-Filterd-Recvd-Size: 3883 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 17:02:00 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id a9so139633wmj.4 for ; Thu, 19 Mar 2020 10:02:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PkyumrhKl+IK4umX5VdHbEracK2b1KPBfOOKx0h6L24=; b=IRZzvl6YXyLhNbkxImf0EU6YCLFRZqWU0NSAW8jUmSNA9QafypTPsmtdo83IuFQ0zv VfPs2ZSho6WuiZI1hPPqmR+NPK3Z9W+d1MWMfgu4W9+UHTAi4TIZQegwuitTcNtHTE7f d0RTQdXlUT3RE9+L0Vhb2EKTKP3SPgE7Z9arNBVpy/IDTfAtRduBliaDTOWp5y1W+tRx NvjZaCfzZplq0MDdSATGKzFNrTFoelacQwx4+ycluubgcOPAPsMqhPfNLJLr9G3XBzwF 3WNLLEMCjcEPbSQFj0AnmokOUnWyqdbAkewyJvuBBvrZm0t6WfVbLZy7PcplBPgkt3iT 5SYQ== X-Gm-Message-State: ANhLgQ0OGXjtJsmRJ9rQSHUoFb6FzI1h7nq6NVwxNB8NItivbGi4adRP c4ei/7i4AolbKySusgT9miU= X-Google-Smtp-Source: ADFU+vsychoHHE53awpsghaJtibw5fq6M0ru8rgive+O5/VYOIjamoecJaSqPzGjJCrG1mj9YupJ/Q== X-Received: by 2002:a1c:bb86:: with SMTP id l128mr4690014wmf.41.1584637319242; Thu, 19 Mar 2020 10:01:59 -0700 (PDT) Received: from localhost (ip-37-188-140-107.eurotel.cz. [37.188.140.107]) by smtp.gmail.com with ESMTPSA id z4sm3304501wrl.85.2020.03.19.10.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 10:01:58 -0700 (PDT) Date: Thu, 19 Mar 2020 18:01:52 +0100 From: Michal Hocko To: Rik van Riel Cc: Roman Gushchin , Aslan Bakirov , Andrew Morton , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, Andreas Schaufler , Mike Kravetz , Guido =?iso-8859-1?Q?G=FCnther?= , Naresh Kamboju Subject: Re: [PATCH] mm: hugetlb: fix hugetlb_cma_reserve() if CONFIG_NUMA isn't set Message-ID: <20200319170152.GJ20800@dhcp22.suse.cz> References: <20200318153424.3202304-1-guro@fb.com> <20200318161625.GR21362@dhcp22.suse.cz> <20200318175529.GA6263@carbon.dhcp.thefacebook.com> <20200319161644.GH20800@dhcp22.suse.cz> <3f75f55dc6a9b4dfd3c6ac808c370bfd91d1554a.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f75f55dc6a9b4dfd3c6ac808c370bfd91d1554a.camel@surriel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 19-03-20 12:56:34, Rik van Riel wrote: > On Thu, 2020-03-19 at 17:16 +0100, Michal Hocko wrote: > > > > This is not the first time HAVE_MEMBLOCK_NODE_MAP has been > > problematic. > > I might be missing something but I really do not get why do we really > > need it these days. As for !NUMA, I suspect we can make it generate > > the > > right thing when !NUMA. > > We're working on a different fix now. > > It looks like cma_declare_contiguous calls memblock_phys_alloc_range, > which calls memblock_alloc_range_nid, which takes a NUMA node as one > of its arguments. > > Aslan is looking at simply adding a cma_declare_contiguous_nid, which > also takes a NUMA node ID as an argument. At that point we can simply > leave CMA free to allocate from anywhere in each NUMA node, which by > default already happens from the top down. > > That should be the nicer long term fix to this issue. Yes, that sounds like a better solution. Not that I would be much happier to have HAVE_MEMBLOCK_NODE_MAP off the table as well ;) Ohh well, it will have to remain on my todo list for some longer. -- Michal Hocko SUSE Labs