From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3569C4332B for ; Thu, 19 Mar 2020 11:50:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9989B2071C for ; Thu, 19 Mar 2020 11:50:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Q9ERC6iP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9989B2071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5099E6B0005; Thu, 19 Mar 2020 07:50:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B9CD6B0006; Thu, 19 Mar 2020 07:50:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F7926B0007; Thu, 19 Mar 2020 07:50:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 27AE56B0005 for ; Thu, 19 Mar 2020 07:50:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DF07E4427 for ; Thu, 19 Mar 2020 11:50:30 +0000 (UTC) X-FDA: 76611944220.14.sun83_5bbc89e9b9218 X-HE-Tag: sun83_5bbc89e9b9218 X-Filterd-Recvd-Size: 4335 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 11:50:30 +0000 (UTC) Received: by mail-qt1-f177.google.com with SMTP id i26so1447451qtq.8 for ; Thu, 19 Mar 2020 04:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lBTUj1y9VtUDCn4ytJFEQ/eoQI6G7k2EQxvY7AJpV3c=; b=Q9ERC6iPr6C3r4Aftx8b5gwyrS/P6NkAng74KreczcNsHr53jWHlVKuPvCBBh0StdU b7wzRK/4QaptzavqQqjoxQtuj+QaqaBcHLAt+n2RM2aODrw/YIvYJOcY6oY/jhXWMdNl gFsDyu8l5L6Q4p5/Vec/nQL4ZF96TI6lmJ+GksJOA5nnA/U56BWjdrmmQuHmwq16PEgF vEDyKh6pD2UZZlm0QaUjZJg9ezYYrp/3bLf3kWlZYm9kIylqHOwtEoZBn6QJwP79CInq PaTsPCn3AYjQRE8u84qlU4iAzPC4kAqGszh17G2RZLFuZX+xqHCLjAuidtRaW2LMrHIM 4mJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lBTUj1y9VtUDCn4ytJFEQ/eoQI6G7k2EQxvY7AJpV3c=; b=c+zDqB06shQU0OBxQ7+fg9tuYVtld77ILta/uH5PSsYiQcbcIFnEvfJLq+0qN4Bcso EzhEJxbQnzjya3toYNH8epDpO5oTBEAQrITAUyYHXWL75rbNYMYsRkFgNMHy5z79cT2B 2fg5FVmLrxBjXf9iA27kcRjxqODe2UuW3V8TSihOtffMo20rFkZ1Pk9a3mzDI3XFkM2Q BrQFQqx9aK35kRChj+SigPahqw0ubXP2CEPbsWIO7KArACounPSAY3+9hiUOIpW7OESr n/oDGrdA1HKem6T+afKVHgAyvRubFJADtK0XuTprLu6miDwGhddhOXDHGseiyExkszwD yhtw== X-Gm-Message-State: ANhLgQ1dSuQidPD+dPnAlsHXt69lU/RqZpz0e3FtLDjS992sXNhTCkcM k8rMM0iktlmEW+wVlHINxF3Bxw== X-Google-Smtp-Source: ADFU+vsIVebb1InTyDcl4fZPuH+UAvQ5tH6FZmi6I4UE9Qq4JBH+2FeGy/XT9qJsD57BNhHjEf5qDA== X-Received: by 2002:ac8:24a7:: with SMTP id s36mr2441422qts.357.1584618629621; Thu, 19 Mar 2020 04:50:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id h138sm1339362qke.86.2020.03.19.04.50.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Mar 2020 04:50:28 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jEtgx-0004ip-P2; Thu, 19 Mar 2020 08:50:27 -0300 Date: Thu, 19 Mar 2020 08:50:27 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: ensure device private pages have an owner v2 Message-ID: <20200319115027.GI20941@ziepe.ca> References: <20200316193216.920734-1-hch@lst.de> <20200319002849.GG20941@ziepe.ca> <20200319071633.GA32522@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319071633.GA32522@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 19, 2020 at 08:16:33AM +0100, Christoph Hellwig wrote: > On Wed, Mar 18, 2020 at 09:28:49PM -0300, Jason Gunthorpe wrote: > > > Changes since v1: > > > - split out the pgmap->owner addition into a separate patch > > > - check pgmap->owner is set for device private mappings > > > - rename the dev_private_owner field in struct migrate_vma to src_owner > > > - refuse to migrate private pages if src_owner is not set > > > - keep the non-fault device private handling in hmm_range_fault > > > > I'm happy enough to take this, did you have plans for a v3? > > I think the only open question is if merging 3 and 4 might make sense. > It's up to you if you want it resent that way or not. Now that I understand that amdgpu doesn't set the 'do not return device_private pages' flag, I think the split is fine, I'll grab it as is then today Thanks, Jason