From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5EABC10DCE for ; Wed, 18 Mar 2020 14:42:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D6BF20775 for ; Wed, 18 Mar 2020 14:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h8UR69SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D6BF20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1955B6B0089; Wed, 18 Mar 2020 10:42:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 146626B008A; Wed, 18 Mar 2020 10:42:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 035346B008C; Wed, 18 Mar 2020 10:42:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id DD9956B0089 for ; Wed, 18 Mar 2020 10:42:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B7CCA180AD804 for ; Wed, 18 Mar 2020 14:42:02 +0000 (UTC) X-FDA: 76608747684.30.crib98_4c0723fb8b426 X-HE-Tag: crib98_4c0723fb8b426 X-Filterd-Recvd-Size: 4427 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Mar 2020 14:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584542521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T7kBegBwWcEdb3wj4I7SyRaROqMrOxZ30lybsvlhbDs=; b=h8UR69SXKDY4t+rFDD7bmkVsh1Bp7zssvFRFRVUDCpa2fZ2ADZNoSUZ6pzFVy3SFL3fRUG 0hJgIJOlP+f0MN3Pa+Xtyos/3R7DbfQo1OKG/XZKqJcZfFmXq6zXa1KPIlmU2TvMSSbFYH 9R6RUicaKCDY5t9XxuLqcHPzeRHu5P4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-pO2FWBMJMNunXEjOqVSYpA-1; Wed, 18 Mar 2020 10:42:00 -0400 X-MC-Unique: pO2FWBMJMNunXEjOqVSYpA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7D2BA1361; Wed, 18 Mar 2020 14:41:57 +0000 (UTC) Received: from localhost (ovpn-12-66.pek2.redhat.com [10.72.12.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FBE160BFB; Wed, 18 Mar 2020 14:41:48 +0000 (UTC) Date: Wed, 18 Mar 2020 22:41:46 +0800 From: Baoquan He To: Michal Hocko Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, Vitaly Kuznetsov , Yumei Huang , Igor Mammedov , Eduardo Habkost , Milan Zamazal , Andrew Morton , Benjamin Herrenschmidt , Greg Kroah-Hartman , Haiyang Zhang , "K. Y. Srinivasan" , Michael Ellerman , Oscar Salvador , Paul Mackerras , "Rafael J. Wysocki" , Stephen Hemminger , Wei Liu , Wei Yang Subject: Re: [PATCH v2 0/8] mm/memory_hotplug: allow to specify a default online_type Message-ID: <20200318144146.GE30899@MiWiFi-R3L-srv> References: <20200317104942.11178-1-david@redhat.com> <20200318130517.GC30899@MiWiFi-R3L-srv> <20200318135408.GP21362@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318135408.GP21362@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/18/20 at 02:54pm, Michal Hocko wrote: > On Wed 18-03-20 21:05:17, Baoquan He wrote: > > On 03/17/20 at 11:49am, David Hildenbrand wrote: > > > Distributions nowadays use udev rules ([1] [2]) to specify if and > > > how to online hotplugged memory. The rules seem to get more complex with > > > many special cases. Due to the various special cases, > > > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE cannot be used. All memory hotplug > > > is handled via udev rules. > > > > > > Everytime we hotplug memory, the udev rule will come to the same > > > conclusion. Especially Hyper-V (but also soon virtio-mem) add a lot of > > > memory in separate memory blocks and wait for memory to get onlined by user > > > space before continuing to add more memory blocks (to not add memory faster > > > than it is getting onlined). This of course slows down the whole memory > > > hotplug process. > > > > > > To make the job of distributions easier and to avoid udev rules that get > > > more and more complicated, let's extend the mechanism provided by > > > - /sys/devices/system/memory/auto_online_blocks > > > - "memhp_default_state=" on the kernel cmdline > > > to be able to specify also "online_movable" as well as "online_kernel" > > > > This patch series looks good, thanks. Since Andrew has merged it to -mm again, > > I won't add my Reviewed-by to bother. > > JFYI, Andrew usually adds R-b or A-b tags as they are posted. Got it, thanks for telling.