From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4414C5ACD8 for ; Wed, 18 Mar 2020 13:54:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8031920767 for ; Wed, 18 Mar 2020 13:54:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8031920767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27BD06B000A; Wed, 18 Mar 2020 09:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2528A6B000C; Wed, 18 Mar 2020 09:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18FFE6B000D; Wed, 18 Mar 2020 09:54:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id F2F916B000A for ; Wed, 18 Mar 2020 09:54:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BE35E824556B for ; Wed, 18 Mar 2020 13:54:12 +0000 (UTC) X-FDA: 76608627144.18.bird79_5ef5636b90b1f X-HE-Tag: bird79_5ef5636b90b1f X-Filterd-Recvd-Size: 4432 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Mar 2020 13:54:12 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id h4so9925794wru.2 for ; Wed, 18 Mar 2020 06:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ngy8A2YvpuwSAkIHITqsxwhgr3uY9q04Wj+xXFxPERw=; b=nd8rDm4UY3yyDe4Hc1BAIYvD1bZpaR65CkRfhuSuNkJYn3zJvD5DMrozfGMhY6caS8 T1Dav07oaaygdUTsZb79KOG5PiimuKsEYFDgZ4sejh8yIpIKu8mHVIKEouKlZQIop1T5 79aMpLBInpwZpnSYXwf4AhX4qaaW9FD9OFE8nsoN7eRZxwvLntXjIHX2DjdCSmbpD5LM CNT5cxfcr/Q8UQdjhBm8wpgsQRB8Q+wJ28cpMvYpPEICVY+APHOX21mS4ZMGf8lKeAve 9Gc6eaDW1OaisD6S0eTSwNRcgWsGtrmmA0ruKbBzg824s4veAUiDmOZMI/Uaa+BWNRCc LUHQ== X-Gm-Message-State: ANhLgQ0mXjJyaKq9NvBc475ALstwMepVlM2B1ULp0AQ4HQBpdmIeY6XS SSZqxetTOxWvoqDoGnQHQ4I= X-Google-Smtp-Source: ADFU+vt7+qT3flEZeTSP4vvFvbKpC/QUOdsY3jrET0kgzQHel35UwsgLvygyXmij4VftsNdLAZApgw== X-Received: by 2002:a05:6000:11d0:: with SMTP id i16mr5649369wrx.319.1584539651261; Wed, 18 Mar 2020 06:54:11 -0700 (PDT) Received: from localhost (ip-37-188-180-89.eurotel.cz. [37.188.180.89]) by smtp.gmail.com with ESMTPSA id n2sm1696410wro.25.2020.03.18.06.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 06:54:10 -0700 (PDT) Date: Wed, 18 Mar 2020 14:54:08 +0100 From: Michal Hocko To: Baoquan He Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, Vitaly Kuznetsov , Yumei Huang , Igor Mammedov , Eduardo Habkost , Milan Zamazal , Andrew Morton , Benjamin Herrenschmidt , Greg Kroah-Hartman , Haiyang Zhang , "K. Y. Srinivasan" , Michael Ellerman , Oscar Salvador , Paul Mackerras , "Rafael J. Wysocki" , Stephen Hemminger , Wei Liu , Wei Yang Subject: Re: [PATCH v2 0/8] mm/memory_hotplug: allow to specify a default online_type Message-ID: <20200318135408.GP21362@dhcp22.suse.cz> References: <20200317104942.11178-1-david@redhat.com> <20200318130517.GC30899@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318130517.GC30899@MiWiFi-R3L-srv> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 18-03-20 21:05:17, Baoquan He wrote: > On 03/17/20 at 11:49am, David Hildenbrand wrote: > > Distributions nowadays use udev rules ([1] [2]) to specify if and > > how to online hotplugged memory. The rules seem to get more complex with > > many special cases. Due to the various special cases, > > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE cannot be used. All memory hotplug > > is handled via udev rules. > > > > Everytime we hotplug memory, the udev rule will come to the same > > conclusion. Especially Hyper-V (but also soon virtio-mem) add a lot of > > memory in separate memory blocks and wait for memory to get onlined by user > > space before continuing to add more memory blocks (to not add memory faster > > than it is getting onlined). This of course slows down the whole memory > > hotplug process. > > > > To make the job of distributions easier and to avoid udev rules that get > > more and more complicated, let's extend the mechanism provided by > > - /sys/devices/system/memory/auto_online_blocks > > - "memhp_default_state=" on the kernel cmdline > > to be able to specify also "online_movable" as well as "online_kernel" > > This patch series looks good, thanks. Since Andrew has merged it to -mm again, > I won't add my Reviewed-by to bother. JFYI, Andrew usually adds R-b or A-b tags as they are posted. -- Michal Hocko SUSE Labs