From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68F3C10DCE for ; Wed, 18 Mar 2020 08:15:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FD552076C for ; Wed, 18 Mar 2020 08:15:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FD552076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 10B716B0003; Wed, 18 Mar 2020 04:15:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0954D6B0006; Wed, 18 Mar 2020 04:15:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9D096B0007; Wed, 18 Mar 2020 04:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id CD3C36B0003 for ; Wed, 18 Mar 2020 04:15:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A281C181AEF09 for ; Wed, 18 Mar 2020 08:15:54 +0000 (UTC) X-FDA: 76607774628.09.guide99_339376c146d0e X-HE-Tag: guide99_339376c146d0e X-Filterd-Recvd-Size: 2846 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Mar 2020 08:15:54 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id r7so1685898wmg.0 for ; Wed, 18 Mar 2020 01:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u1Vg0mBLvEo3DD8HGaqtItvQ6lzE59walEAWqglake0=; b=qHsbMBJANVWI2uX+OZwZYBawuPgxJ8xdfK5O1JZ+4NkyOby5HfRKWFKK97AaNlq9/H 71/XthWqj0vmmlSyWDB0UDUIScFYV0n8Yg2fPNJv2t6hEFBNVM+7+qheW191BjHxAp/j bZgrU0oIgydZb3djDziSoSYrBGPRjf14hzhIGXo+rt/iSm1bhGjbM4MB+mSTqOKxGVNA hLSvtPgFrZdEn56PRrCVAoN3AK+RgVXRkCPGCK6qs+yQyIKBhdXyRd67OMBds68Cu9Go sCEP98aRP+QISdobCXpyG7feDUjSM+BBM0jJtJwVGnrB8EPceKEH1YEBxx1ZT4RDllpA d1UA== X-Gm-Message-State: ANhLgQ3Ck5Ag/Ps929h9iagcgZbwuFy5paSClEccQlS+uNJca/ModDf3 hbeLnGd3213+yj9uYo8FVc4= X-Google-Smtp-Source: ADFU+vv9coRwTHLE3umhggTpYzUH3ioL4391no4/tGzs7VITeqhq16r6w1jTqgWDnBBfQ6gbdU5Wng== X-Received: by 2002:a7b:c414:: with SMTP id k20mr3787266wmi.119.1584519352976; Wed, 18 Mar 2020 01:15:52 -0700 (PDT) Received: from localhost (ip-37-188-180-89.eurotel.cz. [37.188.180.89]) by smtp.gmail.com with ESMTPSA id k3sm508962wmf.16.2020.03.18.01.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 01:15:51 -0700 (PDT) Date: Wed, 18 Mar 2020 09:15:51 +0100 From: Michal Hocko To: Matthew Wilcox Cc: Yang Shi , shakeelb@google.com, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v3 PATCH 1/2] mm: swap: make page_evictable() inline Message-ID: <20200318081551.GC21362@dhcp22.suse.cz> References: <1584466971-110029-1-git-send-email-yang.shi@linux.alibaba.com> <20200317190411.GD22433@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317190411.GD22433@bombadil.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 17-03-20 12:04:11, Matthew Wilcox wrote: [...] > In fact, since it's only called by those three files, perhaps it should > be in mm/internal.h? I don't see it becoming a terribly popular function > to call outside of the core mm code. Agreed. I do not see any strong reasons why anything outside of the core MM should care about evictability. So if moving it to internal.h is reasonable without too much churn then I would that way. -- Michal Hocko SUSE Labs