From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C190EC3F2CE for ; Tue, 17 Mar 2020 10:58:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8380E20735 for ; Tue, 17 Mar 2020 10:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8380E20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2CBB66B0005; Tue, 17 Mar 2020 06:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C9A6B0006; Tue, 17 Mar 2020 06:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16BE46B0007; Tue, 17 Mar 2020 06:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id F27646B0005 for ; Tue, 17 Mar 2020 06:58:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B3FC5181AEF0B for ; Tue, 17 Mar 2020 10:58:21 +0000 (UTC) X-FDA: 76604555202.16.pen37_66127d957ff0c X-HE-Tag: pen37_66127d957ff0c X-Filterd-Recvd-Size: 4833 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 10:58:21 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id b2so18776080wrj.10 for ; Tue, 17 Mar 2020 03:58:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GMaxJmgHFs3UkzWKRUJIGAMAuAis9ucYU7WNuhbnrM0=; b=COD+8c+LU8VJRCRZAGg2uSFHSbNSF2xNiKgcH77+jdNlXztDacSsHNEXdsOETPU6ew 8feMTHlHkK7V7Hzi2OmDikcAMPHex7m51qSd4Thqmv0epCF9y6HiCWyUMa9A30Hrx/Pj bP+Zdlit2nff4MWl5RPS+sUWdcB7jeFCRE8q0CIw8Z2QM23z3bMIBUqFmCAvLP1EhV1k ul26F5fQrSNuF46t3QSbpR5sct/62eFxZTqu30dK7Y1YOhl0HW/X7xduFU/D+vATzU/z AmT/c6exTAe0nERHkx6MOaiCwiNQsEo0WyzWt8wIbzkw2QUiNq7QGoAjVOiK94968Gtb eILQ== X-Gm-Message-State: ANhLgQ3YVX6kOFCG8PEIMjhozrdkRWxrbxmC9v4R9PdV047VRw0FtwfE UvVrgbMQjRieGhS8bAvrk6E= X-Google-Smtp-Source: ADFU+vuwMUcRYGkxYv04ItK19Y8hWebnnNI8rNDKcJ7IZEFzRgxAHrUzVDn0iHSETvqcL5o3Rxedng== X-Received: by 2002:a05:6000:1186:: with SMTP id g6mr5358405wrx.331.1584442700152; Tue, 17 Mar 2020 03:58:20 -0700 (PDT) Received: from localhost (ip-37-188-255-121.eurotel.cz. [37.188.255.121]) by smtp.gmail.com with ESMTPSA id y189sm3615478wmb.26.2020.03.17.03.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 03:58:19 -0700 (PDT) Date: Tue, 17 Mar 2020 11:58:18 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , Greg Kroah-Hartman , Oscar Salvador , "Rafael J. Wysocki" , Baoquan He , Wei Yang Subject: Re: [PATCH v2 4/8] powernv/memtrace: always online added memory blocks Message-ID: <20200317105818.GK26018@dhcp22.suse.cz> References: <20200317104942.11178-1-david@redhat.com> <20200317104942.11178-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317104942.11178-5-david@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 17-03-20 11:49:38, David Hildenbrand wrote: > Let's always try to online the re-added memory blocks. In case add_memory() > already onlined the added memory blocks, the first device_online() call > will fail and stop processing the remaining memory blocks. > > This avoids manually having to check memhp_auto_online. > > Note: PPC always onlines all hotplugged memory directly from the kernel > as well - something that is handled by user space on other > architectures. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: "Rafael J. Wysocki" > Cc: Baoquan He > Cc: Wei Yang > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: David Hildenbrand Acked-by: Michal Hocko > --- > arch/powerpc/platforms/powernv/memtrace.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c > index d6d64f8718e6..13b369d2cc45 100644 > --- a/arch/powerpc/platforms/powernv/memtrace.c > +++ b/arch/powerpc/platforms/powernv/memtrace.c > @@ -231,16 +231,10 @@ static int memtrace_online(void) > continue; > } > > - /* > - * If kernel isn't compiled with the auto online option > - * we need to online the memory ourselves. > - */ > - if (!memhp_auto_online) { > - lock_device_hotplug(); > - walk_memory_blocks(ent->start, ent->size, NULL, > - online_mem_block); > - unlock_device_hotplug(); > - } > + lock_device_hotplug(); > + walk_memory_blocks(ent->start, ent->size, NULL, > + online_mem_block); > + unlock_device_hotplug(); > > /* > * Memory was added successfully so clean up references to it > -- > 2.24.1 -- Michal Hocko SUSE Labs