From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E45C0044D for ; Mon, 16 Mar 2020 22:16:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3691020674 for ; Mon, 16 Mar 2020 22:16:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A5Vv3DiQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3691020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBDE26B0005; Mon, 16 Mar 2020 18:16:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B961C6B0007; Mon, 16 Mar 2020 18:16:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83C46B0008; Mon, 16 Mar 2020 18:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 921396B0005 for ; Mon, 16 Mar 2020 18:16:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7345D8245571 for ; Mon, 16 Mar 2020 22:16:53 +0000 (UTC) X-FDA: 76602636306.16.unit49_1e9ce25b7841 X-HE-Tag: unit49_1e9ce25b7841 X-Filterd-Recvd-Size: 3974 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 22:16:53 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id t2so13179199wrx.12 for ; Mon, 16 Mar 2020 15:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S8JSIVJc8hBC+f06nZTFPR0p1Zl2SoUOHTZdVV+bVfY=; b=A5Vv3DiQIbfRSJv7uqZ5fY3XPteie2VbktlftTTVVWcjL0Amblo3pOEE+jfyt9yZHN tE8B976jEnbzlJPjwhTcFZz5UNBBpwmdr15ARC+uTnWr1Daq8aYuvu4mggOoElN4mgt3 IdnjfVM3aXeiNm9Hoq1XYirqDlPrGAX66tGqb9ZmIhG4IXAQ1X/t1vs4/sTXAfGsGzpf loLe4BKtgUDm3IiF4xmThYdk54MZTNljl2wqstzw9eWZnrsnP3tg2GKhtS+qQsLqf6Vj AKtvxnuy1QUG1uDE3F+sfjv8q0gEMv8XgwKIQD2tA7z8nTQ7H2DWmI6Rig36QGl7qf4t bmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=S8JSIVJc8hBC+f06nZTFPR0p1Zl2SoUOHTZdVV+bVfY=; b=ZVS5jz6GjfAVFOnODS4Uv/O1gkEEue1HTrl4/zMs+wo71Uya9IaZ4PkEVxlaz/Vc/G VE/hUIcQQo6BEcGf1Arsq7p6oiRFGbyKwb0pzgtWDkliSKVz1KaoPAdJvp2SpEqkpgJv YHsqfbtYF+zK9Lvg9kqmtm+EJKHq+4fBXOe8d82UZhMCAnehXo2oPOYg2QBUoLorS6DT PyhLh/sZJuITpV8sgIBsW9OAEAE3bjqCN5NW3dLPEm0/cSrHdV/0bs7VBNJutEjdRLom ERH+MVTroQdPzGBrXT0HXaAcoc3C5YrfTe5Aysuxg7hajZnI0syhKae7TniM81LFVuA7 ey3w== X-Gm-Message-State: ANhLgQ2IjMy4vwVvhRylzSiQBsy9dPo8X7krjgME3NjjL96UXGeshZ2o hZsaAEjcT96UzeLs2QrgHtc= X-Google-Smtp-Source: ADFU+vse1oKkwdvXItJohl4s4XqPs4btnr1psEXCZPSDssQaCTO12dAzDLte2Fwb/Z4L5RV+sy7bZg== X-Received: by 2002:adf:a483:: with SMTP id g3mr1611117wrb.403.1584397011889; Mon, 16 Mar 2020 15:16:51 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id s131sm1305558wmf.35.2020.03.16.15.16.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Mar 2020 15:16:51 -0700 (PDT) Date: Mon, 16 Mar 2020 22:16:51 +0000 From: Wei Yang To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, richard.weiyang@gmail.com, vbabka@suse.cz Subject: Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given node Message-ID: <20200316221651.nkif7tdkks5cmlnm@master> Reply-To: Wei Yang References: <20200316102150.16487-1-bhe@redhat.com> <20200316102150.16487-2-bhe@redhat.com> <20200316125625.GH3486@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316125625.GH3486@MiWiFi-R3L-srv> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 08:56:25PM +0800, Baoquan He wrote: >When allocating memmap for hot added memory with the classic sparse, the >specified 'nid' is ignored in populate_section_memmap(). > >While in allocating memmap for the classic sparse during boot, the node >given by 'nid' is preferred. And VMEMMAP prefers the node of 'nid' in >both boot stage and memory hot adding. So seems no reason to not respect >the node of 'nid' for the classic sparse when hot adding memory. > >Use kvmalloc_node instead to use the passed in 'nid'. > >Signed-off-by: Baoquan He >Acked-by: Michal Hocko >Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: Wei Yang -- Wei Yang Help you, Help me