From: Wei Yang <richard.weiyang@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, akpm@linux-foundation.org, david@redhat.com,
willy@infradead.org, richard.weiyang@gmail.com, vbabka@suse.cz
Subject: Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given node
Date: Mon, 16 Mar 2020 22:16:51 +0000 [thread overview]
Message-ID: <20200316221651.nkif7tdkks5cmlnm@master> (raw)
In-Reply-To: <20200316125625.GH3486@MiWiFi-R3L-srv>
On Mon, Mar 16, 2020 at 08:56:25PM +0800, Baoquan He wrote:
>When allocating memmap for hot added memory with the classic sparse, the
>specified 'nid' is ignored in populate_section_memmap().
>
>While in allocating memmap for the classic sparse during boot, the node
>given by 'nid' is preferred. And VMEMMAP prefers the node of 'nid' in
>both boot stage and memory hot adding. So seems no reason to not respect
>the node of 'nid' for the classic sparse when hot adding memory.
>
>Use kvmalloc_node instead to use the passed in 'nid'.
>
>Signed-off-by: Baoquan He <bhe@redhat.com>
>Acked-by: Michal Hocko <mhocko@suse.com>
>Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-03-16 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 10:21 [PATCH v4 1/2] mm/sparse.c: Use kvmalloc/kvfree to alloc/free memmap for the classic sparse Baoquan He
2020-03-16 10:21 ` [PATCH v4 2/2] mm/sparse.c: allocate memmap preferring the given node Baoquan He
2020-03-16 12:56 ` [PATCH v5 " Baoquan He
2020-03-16 16:28 ` Pankaj Gupta
2020-03-16 16:29 ` David Hildenbrand
2020-03-16 22:16 ` Wei Yang [this message]
2020-03-24 1:07 ` Baoquan He
2020-03-16 11:00 ` [PATCH v4 1/2] mm/sparse.c: Use kvmalloc/kvfree to alloc/free memmap for the classic sparse David Hildenbrand
2020-03-16 12:40 ` Baoquan He
2020-03-16 11:17 ` Pankaj Gupta
2020-03-16 12:18 ` Matthew Wilcox
2020-03-16 12:54 ` [PATCH v5 " Baoquan He
2020-03-16 22:16 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316221651.nkif7tdkks5cmlnm@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox