From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E047C0044D for ; Mon, 16 Mar 2020 16:44:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D40020679 for ; Mon, 16 Mar 2020 16:44:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="M3K2KNCK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D40020679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A8A46B0037; Mon, 16 Mar 2020 12:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05A0C6B006C; Mon, 16 Mar 2020 12:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB1606B006E; Mon, 16 Mar 2020 12:44:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id D08B56B0037 for ; Mon, 16 Mar 2020 12:44:20 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7B1E28248047 for ; Mon, 16 Mar 2020 16:44:20 +0000 (UTC) X-FDA: 76601798280.20.sink58_8bf89af90f00 X-HE-Tag: sink58_8bf89af90f00 X-Filterd-Recvd-Size: 3639 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:44:19 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id n1so5426550qvz.4 for ; Mon, 16 Mar 2020 09:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+Uq6p9g2nBIlsXg6WLrTw3ShU1TxyczdSfedgnyH/ew=; b=M3K2KNCKpmJZ02PIpDhAo80jFLt/j12YtZG6Y3IxHXQ/JUHbdmx3RwYUU+JRIHye7q 3/7BWIRN99Rxhi8s6ZBCBjwoOw5QR7P+q12780tD4UJtNdIxbfRxCb9pQsbyOUnxi/JT clJiOPrmnMTzz+40XMjXFtzHbnGDL9Yi4WpC870ZRJZnZikRSEDeAI33Soe+n7a4XhrU UUvv0PYbe6fPwlSJS/gfB+tZbXQL2TkhmJUa22hLgyXhqdQjnaZp6LrG7IsMEjGPOMWU +NVTLQdCAXuynhwUEFlDZesXRTs0/hgGGY/uyoTbrSb5E/Hka2k0usl5i/kMX8trhoif /HiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+Uq6p9g2nBIlsXg6WLrTw3ShU1TxyczdSfedgnyH/ew=; b=PYEvZ6S6tkFXPi7H84AhOgNg0VnxroPht/axcAbWJRbfC1WzkMvsMoWUIc/d9yOViC nNoSbZaDy5RKwKDBzz6V3eiCh7zg0Zvz99Q/LMpQL8omb9ccGpbzZpz1yOB4UxLWESAW 5Vc8t5GxICpIr9kWkdTm2IbAZllugTzuS+2qso0Me71C0YGOZ6WSLklO0HHAwIdJjjKg w2RPwNPo8bQn2vzeyUv6LLRhhtzA5JiGuxCKhApHxUHMUEF6hMkjhkMTtHuO9BsxTKH1 7vktiZpcf+am9x1kIBECCiJTZN0HnQaPhRa3MG92qh10QNKKM/qC286A421+tvyxFLFD Ysvw== X-Gm-Message-State: ANhLgQ04zJSpOoBttBPXqH70t1sF0rJw59n8U8dFYT91KqO3q+hQeljI 2utMWv4RI2PtFmm6SBjhvawRZjIWvw7rKg== X-Google-Smtp-Source: ADFU+vvZ0btseIDF78w9zayKZjkOqzOYfSxVYfnwnd5ZAlJ4r4qdDAURspsxjhh259JvZ+JHi9KQQQ== X-Received: by 2002:a0c:a602:: with SMTP id s2mr698894qva.222.1584377059628; Mon, 16 Mar 2020 09:44:19 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id f16sm153457qtk.61.2020.03.16.09.44.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Mar 2020 09:44:19 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jDsqg-0007GP-Gb; Mon, 16 Mar 2020 13:44:18 -0300 Date: Mon, 16 Mar 2020 13:44:18 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: [PATCH 2/5] mm: remove the unused HMM_FAULT_ALLOW_RETRY flag Message-ID: <20200316164418.GG20941@ziepe.ca> References: <20200316135310.899364-1-hch@lst.de> <20200316135310.899364-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316135310.899364-3-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 02:53:07PM +0100, Christoph Hellwig wrote: > The HMM_FAULT_ALLOW_RETRY isn't used anywhere in the tree. Remove it > and the weird -EAGAIN handling where handle_mm_fault drops the mmap_sem. > > Signed-off-by: Christoph Hellwig > --- > include/linux/hmm.h | 5 ----- > mm/hmm.c | 7 ------- > 2 files changed, 12 deletions(-) No objection from me Reviewed-by: Jason Gunthorpe Jason