From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A97C18E5B for ; Mon, 16 Mar 2020 16:13:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D9F320674 for ; Mon, 16 Mar 2020 16:13:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Z6fboPME" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D9F320674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF1246B0007; Mon, 16 Mar 2020 12:13:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC8796B0008; Mon, 16 Mar 2020 12:13:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04EE6B000A; Mon, 16 Mar 2020 12:13:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id C3F706B0007 for ; Mon, 16 Mar 2020 12:13:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4DE8549961F for ; Mon, 16 Mar 2020 16:13:30 +0000 (UTC) X-FDA: 76601720580.10.mask95_1e8967e9f6041 X-HE-Tag: mask95_1e8967e9f6041 X-Filterd-Recvd-Size: 3706 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:13:29 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id f28so27106563qkk.13 for ; Mon, 16 Mar 2020 09:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MfbIGBc63hzvaI2AjhmQGq4X01IizPj1vckVgt6cE14=; b=Z6fboPME5eE2zk22FztnS6AC+ygfbWbrvd0GV/aPzJXFF7BOitZfSfphe7G5SGLDKO EaG13j4Bu+sJvDyzzAZGhqzRILxSdKeBbIgrtGJ5hbYof9Xnm3eQjrSz7AN9XyfliGIX nz+tC7bc3qNSw/onBelQEtbGkk8b0uBunLiBzLjap56J0SIOMqgmWNc32ltwDcboaqMK BWrsk52YTeZLvsCTA+d7oEjQ9ZF3ZLiQeOZNTu9qNkp+Eq1gUxWTmzFlt/6YIQ9ilaz7 JOIwZSc5Vr4WakJZygmy8z5zwqyp6idd4ANSthrp/LpIGaE2ZF7J8QGS7YXpKAEKWV5T GXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MfbIGBc63hzvaI2AjhmQGq4X01IizPj1vckVgt6cE14=; b=hFqH0UDmstNhspIG2kpBOG8jYlw7XDjcTnXsijuQBrOBMUrInuNZfHzD+WZ9tqWJM6 JvIAskiIy1giNPmq20LQZ1oGZuN8xh/tUSqCfZsuzebyrMgAPwqi3x7+JUQavAY62Os0 ggUOR1DghB4Wez2Sd25NF85FgunzAmAkbtnl512JrpAUtQKpAhO9aJw/1NLMQERm/hX2 UzkEgqXP0wC+zLpPvodJ0dSxw7TLer+iH9TPqzJuea7TOq8Kh8VgGmsNtYmzkT8xRIZ5 hOwgF/HkpJK0Ye/s3jI20nKvk0Ik7qd0sCndzpVoKHV3X+XehozsAVZQ2cO3s6UkzK5l yARQ== X-Gm-Message-State: ANhLgQ1T/UxqkQsapyqa3TdHhmzLknxEP1mFSO+ou2Hj133YEx1KM8mZ /+Riziukkg1FvtcUFmosVDdtlw== X-Google-Smtp-Source: ADFU+vsVGfndOoHO//HLE/DL7hovHJD5skuz/7ebMx9g/pExAzenBq3qv99ouVtyhB8siwK0Ny7Jlw== X-Received: by 2002:a37:e40d:: with SMTP id y13mr428529qkf.39.1584375209267; Mon, 16 Mar 2020 09:13:29 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id r29sm88711qtj.76.2020.03.16.09.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 09:13:28 -0700 (PDT) Date: Mon, 16 Mar 2020 12:13:27 -0400 From: Johannes Weiner To: Yafang Shao Cc: akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] psi: move PF_MEMSTALL out of task->flags Message-ID: <20200316161327.GC67986@cmpxchg.org> References: <1584355585-10210-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584355585-10210-1-git-send-email-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 06:46:25AM -0400, Yafang Shao wrote: > The task->flags is a 32-bits flag, in which 31 bits have already been > consumed. So it is hardly to introduce other new per process flag. > Currently there're still enough spaces in the bit-field section of > task_struct, so we can define the memstall state as a single bit in > task_struct instead. > > Suggested-by: Johannes Weiner > Signed-off-by: Yafang Shao Thanks for reworking it. This looks good to me. Acked-by: Johannes Weiner