From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC66C18E5B for ; Mon, 16 Mar 2020 12:18:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE4B720663 for ; Mon, 16 Mar 2020 12:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s4Fa/txq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE4B720663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 62A006B0003; Mon, 16 Mar 2020 08:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DB056B0005; Mon, 16 Mar 2020 08:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9096B0007; Mon, 16 Mar 2020 08:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 367306B0003 for ; Mon, 16 Mar 2020 08:18:57 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E24FE180AD811 for ; Mon, 16 Mar 2020 12:18:56 +0000 (UTC) X-FDA: 76601129472.18.hour26_1399747d60b41 X-HE-Tag: hour26_1399747d60b41 X-Filterd-Recvd-Size: 2428 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 12:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VYqKvlIFkQW+pYWKw2xVsDJi1K3BGJvUDJbFubWL0xw=; b=s4Fa/txqhFusSCj//z0CGHHLnt SzCovk4A9hIakdxXBSWwrUr3oebo6/kI+ZA0GqaiyA1BKdVIOanqg4YpnBT3+oR5qQMz6uK4Nm67i UGhhtL0E6B+4bVcGeaG4B/VZpedBfuRIXuLoXSFtipOh4/usKFOj4Gf7oiEqEXSXYhM1AFr9g290w T/bwvigK4HyMPrFH7bK4sj88OaERz0osPh4BNanoKy2FAxvd7HXC9LPOGxx9i4SkXutYS6NjaCG0v I9Zjp22V1gZGuZQm1vuZeYsKTv53VZBT6DCWT2dZuEH5IXEIbNqo6VgNng5j7+6pir5Ok9dJRc+U7 bpT7PfgA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDohj-00007t-7P; Mon, 16 Mar 2020 12:18:47 +0000 Date: Mon, 16 Mar 2020 05:18:47 -0700 From: Matthew Wilcox To: Pankaj Gupta Cc: Baoquan He , linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, Andrew Morton , David Hildenbrand , richard.weiyang@gmail.com, Vlastimil Babka Subject: Re: [PATCH v4 1/2] mm/sparse.c: Use kvmalloc/kvfree to alloc/free memmap for the classic sparse Message-ID: <20200316121847.GX22433@bombadil.infradead.org> References: <20200316102150.16487-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 12:17:49PM +0100, Pankaj Gupta wrote: > > This change makes populate_section_memmap()/depopulate_section_memmap > > much simpler. > > > > Suggested-by: Michal Hocko > > Signed-off-by: Baoquan He > > Reviewed-by: David Hildenbrand > > Acked-by: Michal Hocko > With David's indentation suggestion: > Reviewed-by: Pankaj Gupta Reviewed-by: Matthew Wilcox (Oracle) (for both patches)