From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A534C0044D for ; Mon, 16 Mar 2020 09:12:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 508E220658 for ; Mon, 16 Mar 2020 09:12:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 508E220658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E0AC76B0005; Mon, 16 Mar 2020 05:12:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBABC6B0007; Mon, 16 Mar 2020 05:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD08A6B0008; Mon, 16 Mar 2020 05:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id B26746B0005 for ; Mon, 16 Mar 2020 05:12:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7D7FE10FAC for ; Mon, 16 Mar 2020 09:12:15 +0000 (UTC) X-FDA: 76600659030.14.ocean36_8816604983748 X-HE-Tag: ocean36_8816604983748 X-Filterd-Recvd-Size: 1699 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 09:12:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0355A68CEC; Mon, 16 Mar 2020 10:12:13 +0100 (CET) Date: Mon, 16 Mar 2020 10:12:12 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: Re: [PATCH hmm 7/8] mm/hmm: return -EFAULT when setting HMM_PFN_ERROR on requested valid pages Message-ID: <20200316091212.GG12439@lst.de> References: <20200311183506.3997-1-jgg@ziepe.ca> <20200311183506.3997-8-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311183506.3997-8-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000167, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 11, 2020 at 03:35:05PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > hmm_range_fault() should never return 0 if the caller requested a valid > page, but the pfns output for that page would be HMM_PFN_ERROR. > > hmm_pte_need_fault() must always be called before setting HMM_PFN_ERROR to > detect if the page is in faulting mode or not. > > Fix two cases in hmm_vma_walk_pmd() and reorganize some of the duplicated > code. Looks good, Reviewed-by: Christoph Hellwig