From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66692C10DCE for ; Sun, 15 Mar 2020 21:57:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 081F420674 for ; Sun, 15 Mar 2020 21:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pNQS/5ds" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 081F420674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63F466B0003; Sun, 15 Mar 2020 17:57:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CAE26B0006; Sun, 15 Mar 2020 17:57:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 490FA6B0007; Sun, 15 Mar 2020 17:57:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 2F0586B0003 for ; Sun, 15 Mar 2020 17:57:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0ED6B180ACEE6 for ; Sun, 15 Mar 2020 21:57:30 +0000 (UTC) X-FDA: 76598958660.04.cream18_41742071b4c31 X-HE-Tag: cream18_41742071b4c31 X-Filterd-Recvd-Size: 4115 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Mar 2020 21:57:29 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id r15so18880395wrx.6 for ; Sun, 15 Mar 2020 14:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HLihB9dC29PEmBSGEnLAUB0v7jZbe0wOo+ZjC92so+E=; b=pNQS/5dsMT2cPgmXpzLLY/wpmbaYMOgwn06it0C7G6X/0Q2PbO/OcRHTUhXVWGwnCp pDQ2IJ0+aAptWSVDFctX3/+BCrOPMhTYaQ4QK0bUgXj4MPq57o8h0ulDxEW8vR9YBqJl ELJEtWmYSoYBqWQWPA5s93ituercEF9Nbe5LQTewH6qjD8/KoecUbSqAOwd9LPUM4BEC qxJCQ/FV32Mkm+iXU7ygsaMpxIdtS2ATd7Fc73V0iURJQJ6Q9XS4uTqMD9c3RURsqPxE q+LO89B4EK7SqxugmjegpALlmg/8G54VfRMxjleSXaWr041zzDRIRnDj0eOLqOX5Mvi3 WyCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=HLihB9dC29PEmBSGEnLAUB0v7jZbe0wOo+ZjC92so+E=; b=IZSJo6dXm2lKlu3H3Jrnl4mKB4LXqLdEAEWyeLRAZdQLY2lDQWkX1ksqWcl8f7FjXA aNvlTmS7/eF5ck5qRLVbzmqdZCBu5KktgkZ5rqIl7r+akgqBAx7Uy/fXMPr3BHANnWGS Z5MM6jtLueMoHgE3p4BevjrKq94oLkOkJ3ULZJQL+1YaE3KZvVYmxvtbHgoVaAF4P3Ek u1LlArnZ8v1m6nge3WYxqsp396xPtEc822U8EzKE59xtDHZAJz415xdt0e7HL2W9l46l r8xIceZoRCmPdo95QqzieR31PHmSOKiULMBAdJScBpR/eDBjn2A5ZW9gX6S8Y+iqEB0G WKug== X-Gm-Message-State: ANhLgQ1wg0/f4V3WdZkVq+Uju9fdCh8AUqcJr7YH6tmmtISpte56ybLU uE9lFqx3jWJY5LMeRydh/dY= X-Google-Smtp-Source: ADFU+vvRB2qgHnmLpUNtf8qGKJ2z1nOnKGdiEZFikcsvlkM8vdQ3CGWyBpA5+6T3RXZs3BuQK02+Hg== X-Received: by 2002:adf:e881:: with SMTP id d1mr31301356wrm.262.1584309418504; Sun, 15 Mar 2020 14:56:58 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id g127sm28318338wmf.10.2020.03.15.14.56.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Mar 2020 14:56:57 -0700 (PDT) Date: Sun, 15 Mar 2020 21:56:57 +0000 From: Wei Yang To: Baoquan He Cc: Wei Yang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, mhocko@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH v2] x86/mm: Remove the redundant conditional check Message-ID: <20200315215657.hojujnc2ru5jd26n@master> Reply-To: Wei Yang References: <20200311011823.27740-1-bhe@redhat.com> <20200314151006.gnkyf4xpqve6b3wx@master> <20200315124913.GA3486@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200315124913.GA3486@MiWiFi-R3L-srv> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 15, 2020 at 08:49:13PM +0800, Baoquan He wrote: >On 03/14/20 at 03:10pm, Wei Yang wrote: >> On Wed, Mar 11, 2020 at 09:18:23AM +0800, Baoquan He wrote: >> >In commit f70029bbaacb ("mm, memory_hotplug: drop CONFIG_MOVABLE_NODE"), >> >the dependency on CONFIG_MOVABLE_NODE was removed for N_MEMORY. Before >> >commit f70029bbaacb, CONFIG_HIGHMEM && !CONFIG_MOVABLE_NODE could make >> >(N_MEMORY == N_NORMAL_MEMORY) be true. After commit f70029bbaacb, N_MEMORY >> >doesn't have any chance to be equal to N_NORMAL_MEMORY. So the conditional >> >check in paging_init() doesn't make sense any more. Let's remove it. >> > >> >Signed-off-by: Baoquan He >> >> The change looks good. While I have one question, we set default value for >> N_HIGH_MEMORY. Why we don't clear this too? > >This is for x86_64 only, there's no node_state for N_HIGH_MEMORY. > Thanks, I see it in arch/x86/Kconfig. -- Wei Yang Help you, Help me