From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6F6C18E5B for ; Sun, 15 Mar 2020 16:03:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91FEA20578 for ; Sun, 15 Mar 2020 16:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="JQNh4D53" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91FEA20578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E746C6B0003; Sun, 15 Mar 2020 12:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24D86B0006; Sun, 15 Mar 2020 12:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13A86B0007; Sun, 15 Mar 2020 12:03:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id B6FCA6B0003 for ; Sun, 15 Mar 2020 12:03:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C0D03180AD838 for ; Sun, 15 Mar 2020 16:03:42 +0000 (UTC) X-FDA: 76598067084.12.vein05_2060b5e76a161 X-HE-Tag: vein05_2060b5e76a161 X-Filterd-Recvd-Size: 2156 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Mar 2020 16:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mxPfarIqbjUZhPb5nQkaPXUh1yhCYouVFUvHtSwUDGM=; b=JQNh4D538Svr63J6jYaKx9G39Z IlVEKG+q6yPIOXW75VEBehECfximavxxhfWCBg8PhqWYFuMV/8VhZgB7FnzOEUb3zno8Ck9qbci7t It54I8kSJ8LEv4FmF+FC56e4t9Epx+Q4qz1VEEZ2+4P1YwF5IKLChaHmyM3hegaNi6hxnTKysE7w/ YsAT4/a677bCG8ExF4g9dR626CS4EGzW/ujs4Tz6voXGtf6MMtFPxriiqPRtR3j5RZGTtd+yUS1Xu FcU52OVYFy3XG8nRDPUoHmW7xonRNN/JJpeRHsI0nPTA775qwZdZpz9HsjdE6SoCfCuSUgUvZfAdQ Y85sLSNg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDVjg-0000nP-Ge; Sun, 15 Mar 2020 16:03:32 +0000 Date: Sun, 15 Mar 2020 09:03:32 -0700 From: Matthew Wilcox To: Yafang Shao Cc: dchinner@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, guro@fb.com, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 1/3] mm, list_lru: make memcg visible to lru walker isolation function Message-ID: <20200315160332.GW22433@bombadil.infradead.org> References: <20200315095342.10178-1-laoar.shao@gmail.com> <20200315095342.10178-2-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200315095342.10178-2-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000336, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 15, 2020 at 05:53:40AM -0400, Yafang Shao wrote: > +#define for_each_mem_cgroup_tree(iter, root) \ > + for (iter = mem_cgroup_iter(root, NULL, NULL); \ > + iter != NULL; \ > + iter = mem_cgroup_iter(root, iter, NULL)) [...] > +#define for_each_mem_cgroup_tree(iter) \ > + for (iter = NULL; iter; ) > + That's not the same signature ...