From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6804C10DCE for ; Sun, 15 Mar 2020 12:22:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E3B520578 for ; Sun, 15 Mar 2020 12:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="chYAt6y0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E3B520578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D8DB6B0005; Sun, 15 Mar 2020 08:22:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 888E96B0006; Sun, 15 Mar 2020 08:22:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7515B6B0007; Sun, 15 Mar 2020 08:22:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 58E4E6B0005 for ; Sun, 15 Mar 2020 08:22:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 192B24DAB for ; Sun, 15 Mar 2020 12:22:21 +0000 (UTC) X-FDA: 76597509282.24.tiger18_88e46d2d42323 X-HE-Tag: tiger18_88e46d2d42323 X-Filterd-Recvd-Size: 4618 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Mar 2020 12:22:20 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id f3so10754073wrw.7 for ; Sun, 15 Mar 2020 05:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/Kx5mSt5kBh7FsLH+0N/pfeCSX6lxtBaeY/mUDaY9J4=; b=chYAt6y0eCvcUVZE3gi3UBUzNUzKL+vQ1CMKCFG1y5sNExXx+3T8iGg0e83kjBmxrm YWmLFF335HRNA7cfnN7z9efqWMpah8o9G5+f28jKF1e4G4yCwB83Q2nieWSKqsz8zf4f +WtQUcWBgizHrzbXLH6FYcUPSIulaR8QifpA6Hn8IoGSYYJMBfR+tKDtX765FwgXq93R PX67+DjGRSnNHhNZYg0a7qjblj627lIvZ6g/JDDcMXNWzIP7GqbemQvAsJP4stqJEv4s pH+LeEsvuP8ljdQg0TjWtOVX2zyy5XDMgasvecY67rK/oc+2X0CrzzzWi9WkG/amCziB 6iow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=/Kx5mSt5kBh7FsLH+0N/pfeCSX6lxtBaeY/mUDaY9J4=; b=gnmss1uzqpUrJtC5+1c0JM7xSJPBTbOJX7fMb7+bLp35gzKJGPVMYmmCQcUXt9cYW2 tAZRPtcx6yXCCpL3lb8FPGtvBvZz792gKgvA300JxYKmuxZNgmRRyVRVTUD2iDnWvFLy MI7pC3CIbf0Klwyf+0p2AQOAraYlbpoMhPYjE/Ec9IuvkbPu5TDMZy4cITKUl1ch0bWS yHtcsDAhQI/uoQ6Cycgzf5E9s3JhZWAGI3QiWdrOdd3xMoZhq/y3ZfkWGaEeLdg89p6J 6SZN9WG2kW/jxFtShudsVK0iBMHMsL5XB7a/J7HGW4ikktY/JdM91yis7zbFqkzi4mtp Zsdg== X-Gm-Message-State: ANhLgQ1rHsSA9mF7uJvck0Z/fhVvYiN7Y1nTA4z08rJoR3rWMO71A5OL wwsj4KbOV9aop+z69vQ7NmA= X-Google-Smtp-Source: ADFU+vt66/Ql4uCVh3eduLr+kYFsxKgtN259zBw/vcwySrA50rU0Bvrq10gHgvRGjWQI7Jq7qzwsIg== X-Received: by 2002:a5d:6a8d:: with SMTP id s13mr29885645wru.260.1584274939361; Sun, 15 Mar 2020 05:22:19 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id x16sm23743836wrg.44.2020.03.15.05.22.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Mar 2020 05:22:18 -0700 (PDT) Date: Sun, 15 Mar 2020 12:22:17 +0000 From: Wei Yang To: Mika Penttil?? Cc: Wei Yang , "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen , David Hildenbrand , Mel Gorman , Vlastimil Babka , Zi Yan , Michal Hocko , Peter Zijlstra , Minchan Kim , Johannes Weiner , Hugh Dickins Subject: Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE Message-ID: <20200315122217.45mioaxzuulwvx2f@master> Reply-To: Wei Yang References: <20200228033819.3857058-1-ying.huang@intel.com> <20200228033819.3857058-3-ying.huang@intel.com> <20200315081854.rcqlmfckeqrh7fbt@master> <92d4b0fe-f592-8da6-0282-2ea8a015b247@nextfour.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92d4b0fe-f592-8da6-0282-2ea8a015b247@nextfour.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 15, 2020 at 10:54:03AM +0200, Mika Penttil?? wrote: > > >On 15.3.2020 10.18, Wei Yang wrote: >> On Fri, Feb 28, 2020 at 11:38:18AM +0800, Huang, Ying wrote: >> > From: Huang Ying >> > >> > Now !PageSwapBacked() is used as the flag for the pages freed lazily >> > via MADV_FREE. This isn't obvious enough. So Dave suggested to add a >> > new page flag for that to improve the code readability. >> I am confused with the usage of PageSwapBacked(). >> >> Previously I thought this flag means the page is swapin, set in >> swapin_readahead(). While I found page_add_new_anon_rmap() would set it too. >> This means every anon page would carry this flag. Then what is this flag >> means? >> >> > >But not all PageSwapBacked() pages are anon, like shmem. > Yes, while it looks shmem is the only exception. I am still struggling to understand the meaning of this flag. > >--Mika -- Wei Yang Help you, Help me