From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4805AC0044D for ; Sat, 14 Mar 2020 16:02:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBDEA2076F for ; Sat, 14 Mar 2020 16:02:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="e7v9xq02" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBDEA2076F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84D1D6B0003; Sat, 14 Mar 2020 12:02:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD256B0006; Sat, 14 Mar 2020 12:02:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73A446B0007; Sat, 14 Mar 2020 12:02:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 583146B0003 for ; Sat, 14 Mar 2020 12:02:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F3BB4824556B for ; Sat, 14 Mar 2020 16:02:05 +0000 (UTC) X-FDA: 76594434252.13.stick89_6999a99203047 X-HE-Tag: stick89_6999a99203047 X-Filterd-Recvd-Size: 2648 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Mar 2020 16:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Jewea45aYiB6s5a1qemOSbdXYRftmqxlJxaA0AoO65U=; b=e7v9xq02aJXSv1wa7j3FndJf1B Vt1+VZfg/qba7aCy+1L1IUopJlYXSjGS/FBdD9TRnHdMzR5B2exScz67xhmAxsoevQhOeEsn5ENo6 +/08M+hMvhh/oe5D5o6mVyxuEzOV1UgKeH1ygmMAQVhkiQtis35E2LOTZ9M1h6WAUfFKcFlKR1yBZ Bn5+x9e0CGBQ4HwQ5M4IOpH8codgzAQFy3+t0GHRLLhUG9S848DuQniUUwaa3vJcGDC4PETsvawEJ YaAhj0S7FMbCH8kaED28RRlyA9fSdP4lTTVZqgDs8CJMKciaBS2mgCLQO1cjqzKEjUgiDDXvDxmnD yPIUMSPA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jD9Ec-0008To-1c; Sat, 14 Mar 2020 16:01:58 +0000 Date: Sat, 14 Mar 2020 09:01:57 -0700 From: Matthew Wilcox To: Yang Shi Cc: shakeelb@google.com, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: swap: make page_evictable() inline Message-ID: <20200314160157.GR22433@bombadil.infradead.org> References: <1584124476-76534-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584124476-76534-1-git-send-email-yang.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 14, 2020 at 02:34:35AM +0800, Yang Shi wrote: > -extern int page_evictable(struct page *page); > +/* This seems to be in kernel-doc format already; could you add the extra '*' so it is added to the fine documentation? > + * page_evictable - test whether a page is evictable > + * @page: the page to test > + * > + * Test whether page is evictable--i.e., should be placed on active/inactive > + * lists vs unevictable list. > + * > + * Reasons page might not be evictable: > + * (1) page's mapping marked unevictable > + * (2) page is part of an mlocked VMA > + * > + */ > +static inline int page_evictable(struct page *page) > +{ > + int ret; > + > + /* Prevent address_space of inode and swap cache from being freed */ > + rcu_read_lock(); > + ret = !mapping_unevictable(page_mapping(page)) && !PageMlocked(page); > + rcu_read_unlock(); > + return ret; > +} This seems like it should return bool ... that might even lead to code generation improvement.