From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB24C0044D for ; Sat, 14 Mar 2020 12:56:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D767E20774 for ; Sat, 14 Mar 2020 12:56:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D767E20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A89B6B0003; Sat, 14 Mar 2020 08:56:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3318F6B0006; Sat, 14 Mar 2020 08:56:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FB0C6B0007; Sat, 14 Mar 2020 08:56:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 0470F6B0003 for ; Sat, 14 Mar 2020 08:56:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D2C30824556B for ; Sat, 14 Mar 2020 12:56:43 +0000 (UTC) X-FDA: 76593967086.28.crowd18_57d46dab90e04 X-HE-Tag: crowd18_57d46dab90e04 X-Filterd-Recvd-Size: 3409 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Mar 2020 12:56:43 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id a25so15561082wrd.0 for ; Sat, 14 Mar 2020 05:56:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cl7WWdndugVK0es2ynV4Gap0u1lguGYoJQLdlgdsR1k=; b=S7iebp0j3/+ryK9AysiZOPoNh6J91reOMAdRZe5y4RgBMyg08jOtArpje7TVJ9KwWE bRFV56TgCGwGMNvv0pnjzNylEhodtXu5StwmnrXywzLg0YS+j9gVxnzm93iNR6XABCSB 11av/fFrrQNIKJL5n+f1miZgX2R1DDh/AvBgK6/9Fnlx27oi/ymdpleCmsVP7LXaw+Ne KCEaDLHyKPTQsKEjKw2J8lSm7WdHznGwltjT6NpJkjK1/rkHtHUl1GqzbMZ5FOrv/0MP aZWwiiuAwRIvS6rPqzlD5dcP6NHQoYQ5uZMaFN+UtToZwVhxis0QHZJ6FnuzBPhkMrU5 2tIA== X-Gm-Message-State: ANhLgQ03v6YAsNrZ5ATTd5wrvhu6ZTMXNKZA0PQFiANcs91gvPWte5YQ aQMnjqtWFO/X9JFQDiEfF+c= X-Google-Smtp-Source: ADFU+vuxlwBxUpjfTjmxexdc27Fw1psiW8V9oY9DcWgyKJ2vzjLtyCJ2iKiohct9r31VozfL4/eRFA== X-Received: by 2002:adf:f8c9:: with SMTP id f9mr7081671wrq.222.1584190602248; Sat, 14 Mar 2020 05:56:42 -0700 (PDT) Received: from localhost (ip-37-188-252-125.eurotel.cz. [37.188.252.125]) by smtp.gmail.com with ESMTPSA id p16sm19736101wmi.40.2020.03.14.05.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2020 05:56:41 -0700 (PDT) Date: Sat, 14 Mar 2020 13:56:38 +0100 From: Michal Hocko To: Baoquan He Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, richard.weiyang@gmail.com Subject: Re: [PATCH v3] mm/sparse.c: Use kvmalloc_node/kvfree to alloc/free memmap for the classic sparse Message-ID: <20200314125638.GC10912@dhcp22.suse.cz> References: <20200312130822.6589-1-bhe@redhat.com> <20200312141749.GL27711@MiWiFi-R3L-srv> <20200313145619.GD21007@dhcp22.suse.cz> <20200314005334.GO27711@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200314005334.GO27711@MiWiFi-R3L-srv> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 14-03-20 08:53:34, Baoquan He wrote: > On 03/13/20 at 03:56pm, Michal Hocko wrote: > > On Thu 12-03-20 22:17:49, Baoquan He wrote: > > > This change makes populate_section_memmap()/depopulate_section_memmap > > > much simpler. > > > > Not only and you should make it more explicit. It also tries to allocate > > memmaps from the target numa node so this is a functional change. I > > would prefer to have that in a separate patch in case we hit some weird > > NUMA setups which would choke on memory less nodes and similar horrors. > > Yes, splitting sounds more reasonable, I would love to do that. One > question is I noticed Andrew had picked this into -mm tree, if I post a > new patchset including these two small patches, whether it's convenient > to drop the old one and get these two merged. Andrew usually just drops the previous version and replaces it by the new one. So just post a new version. Thanks! -- Michal Hocko SUSE Labs