From: Baoquan He <bhe@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, willy@infradead.org,
linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com,
richard.weiyang@gmail.com
Subject: Re: [PATCH v3] mm/sparse.c: Use kvmalloc_node/kvfree to alloc/free memmap for the classic sparse
Date: Sat, 14 Mar 2020 09:12:45 +0800 [thread overview]
Message-ID: <20200314011245.GB8518@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20200313145619.GD21007@dhcp22.suse.cz>
On 03/13/20 at 03:56pm, Michal Hocko wrote:
> On Thu 12-03-20 22:17:49, Baoquan He wrote:
> > This change makes populate_section_memmap()/depopulate_section_memmap
> > much simpler.
>
> Not only and you should make it more explicit. It also tries to allocate
> memmaps from the target numa node so this is a functional change. I
> would prefer to have that in a separate patch in case we hit some weird
> NUMA setups which would choke on memory less nodes and similar horrors.
>
> > Suggested-by: Michal Hocko <mhocko@kernel.org>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> I do not see any reason this shouldn't work. Btw. did you get to test
> it?
Forget replying to this comment. Yes, I have tested it before each post.
next prev parent reply other threads:[~2020-03-14 1:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 13:08 [PATCH v2] " Baoquan He
2020-03-12 13:34 ` Matthew Wilcox
2020-03-12 13:54 ` Baoquan He
2020-03-12 14:18 ` Wei Yang
2020-03-12 14:25 ` Matthew Wilcox
2020-03-12 22:50 ` Wei Yang
2020-03-13 0:00 ` Matthew Wilcox
2020-03-13 14:35 ` David Hildenbrand
2020-03-13 14:46 ` Vlastimil Babka
2020-03-13 14:57 ` Michal Hocko
2020-03-13 21:54 ` Wei Yang
2020-03-12 14:17 ` [PATCH v3] " Baoquan He
2020-03-13 14:56 ` Michal Hocko
2020-03-14 0:53 ` Baoquan He
2020-03-14 12:56 ` Michal Hocko
2020-03-15 13:01 ` Baoquan He
2020-03-14 1:12 ` Baoquan He [this message]
2020-03-13 15:04 ` David Hildenbrand
2020-03-16 7:14 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314011245.GB8518@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox