From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C895BC2BB1D for ; Fri, 13 Mar 2020 14:56:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91E67206FA for ; Fri, 13 Mar 2020 14:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91E67206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F2C66B0007; Fri, 13 Mar 2020 10:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A3D76B0008; Fri, 13 Mar 2020 10:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C1E96B000A; Fri, 13 Mar 2020 10:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 01C2F6B0007 for ; Fri, 13 Mar 2020 10:56:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9F7DC2460 for ; Fri, 13 Mar 2020 14:56:23 +0000 (UTC) X-FDA: 76590639846.08.doll24_37c86fd3b564a X-HE-Tag: doll24_37c86fd3b564a X-Filterd-Recvd-Size: 4670 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Mar 2020 14:56:23 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id v11so12480642wrm.9 for ; Fri, 13 Mar 2020 07:56:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9ElDdxeSYu4NkyRAmxZIQdqY4pRojIvARlsO9YRK9Us=; b=GRR1o4q7Ekg/JwWiVP3Cn+2thUTrksS5wKnsssS9OWr0/tUADNiIK8XfZpQb33H+SP dmSVGeQEEiWhl3z309vKwxrBWqE7Uzktaw+Ioq4218eLf6uUsTap47I1MSpuiU23hXuD nqL6k7byJBdaazAiMZmpKgL5rBmpYJERIFP/t3N20EbGws5Y1IMcjZBIGvN+jFnRIzkW 0srw6LHjm0YAx5J78bN9v0HLOmoSdPHLmRWCvrmOUAu0GEcX37mGeXFJtXMo4x0gtYt8 wS1XdjDpcRh0xgAaqHCqjoIadcI5gAMFjDFMX5g7kOpltz22iWZ0AlTbqdX8BGL3PsOR CTkg== X-Gm-Message-State: ANhLgQ176b9djGWKOe/mFcpOPu9hzXgeImy78OuC2+gNCXSALcMnHC5n 4xPJHDny0paIQlnqgYIyuVw= X-Google-Smtp-Source: ADFU+vue2NbGV7G1Z3URoRGbNmt4diUMnxkBPy4bJadi/+ZMVIcecNH72arlxQKgIIPN16O57+azhQ== X-Received: by 2002:adf:ef81:: with SMTP id d1mr1471759wro.212.1584111382205; Fri, 13 Mar 2020 07:56:22 -0700 (PDT) Received: from localhost (ip-37-188-247-35.eurotel.cz. [37.188.247.35]) by smtp.gmail.com with ESMTPSA id 9sm17160750wmo.38.2020.03.13.07.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 07:56:21 -0700 (PDT) Date: Fri, 13 Mar 2020 15:56:19 +0100 From: Michal Hocko To: Baoquan He Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, richard.weiyang@gmail.com Subject: Re: [PATCH v3] mm/sparse.c: Use kvmalloc_node/kvfree to alloc/free memmap for the classic sparse Message-ID: <20200313145619.GD21007@dhcp22.suse.cz> References: <20200312130822.6589-1-bhe@redhat.com> <20200312141749.GL27711@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312141749.GL27711@MiWiFi-R3L-srv> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 12-03-20 22:17:49, Baoquan He wrote: > This change makes populate_section_memmap()/depopulate_section_memmap > much simpler. Not only and you should make it more explicit. It also tries to allocate memmaps from the target numa node so this is a functional change. I would prefer to have that in a separate patch in case we hit some weird NUMA setups which would choke on memory less nodes and similar horrors. > Suggested-by: Michal Hocko > Signed-off-by: Baoquan He I do not see any reason this shouldn't work. Btw. did you get to test it? Feel free to add Acked-by: Michal Hocko to both patches if you go and split. > --- > v2->v3: > Remove __GFP_NOWARN and use array_size when calling kvmalloc_node() > per Matthew's comments. > > mm/sparse.c | 27 +++------------------------ > 1 file changed, 3 insertions(+), 24 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index bf6c00a28045..bb99633575b5 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -734,35 +734,14 @@ static void free_map_bootmem(struct page *memmap) > struct page * __meminit populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap) > { > - struct page *page, *ret; > - unsigned long memmap_size = sizeof(struct page) * PAGES_PER_SECTION; > - > - page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size)); > - if (page) > - goto got_map_page; > - > - ret = vmalloc(memmap_size); > - if (ret) > - goto got_map_ptr; > - > - return NULL; > -got_map_page: > - ret = (struct page *)pfn_to_kaddr(page_to_pfn(page)); > -got_map_ptr: > - > - return ret; > + return kvmalloc_node(array_size(sizeof(struct page), > + PAGES_PER_SECTION), GFP_KERNEL, nid); > } > > static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages, > struct vmem_altmap *altmap) > { > - struct page *memmap = pfn_to_page(pfn); > - > - if (is_vmalloc_addr(memmap)) > - vfree(memmap); > - else > - free_pages((unsigned long)memmap, > - get_order(sizeof(struct page) * PAGES_PER_SECTION)); > + kvfree(pfn_to_page(pfn)); > } > > static void free_map_bootmem(struct page *memmap) > -- > 2.17.2 > -- Michal Hocko SUSE Labs