From: Jason Gunthorpe <jgg@ziepe.ca>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: jglisse@redhat.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hmm.c : Remove additional check for lockdep_assert_held()
Date: Fri, 13 Mar 2020 09:22:10 -0300 [thread overview]
Message-ID: <20200313122210.GB31668@ziepe.ca> (raw)
In-Reply-To: <1584065460-22205-1-git-send-email-jrdr.linux@gmail.com>
On Fri, Mar 13, 2020 at 07:41:00AM +0530, Souptick Joarder wrote:
> walk_page_range() already has a check for lockdep_assert_held().
> So additional check for lockdep_assert_held() can be removed from
> hmm_range_fault().
Is there a reason why you think this redundancy is bad?
IMHO it makes it easier to understand the API contract if key top
level APIs have their assumptions coded in lockdep.
Jason
next prev parent reply other threads:[~2020-03-13 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 2:11 Souptick Joarder
2020-03-13 2:58 ` Andrew Morton
2020-03-13 3:47 ` Souptick Joarder
2020-03-13 3:57 ` Andrew Morton
2020-03-13 4:22 ` Souptick Joarder
2020-03-13 12:22 ` Jason Gunthorpe [this message]
2020-03-22 15:16 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313122210.GB31668@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox